Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Aug 20, 2018

Description

This PR adds the Request For Comment document for the I2C HAL API overhaul.

This document is meant to serve as the design document for defining what we plan for the API.

Document readable here.

Pull request type:

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

@ithinuel @c1728p9

@ghost
Copy link
Author

ghost commented Oct 11, 2018

@AnotherButler

@cmonr cmonr requested review from a team, AnotherButler, c1728p9 and ithinuel October 18, 2018 22:30
@cmonr
Copy link
Contributor

cmonr commented Oct 25, 2018

@mbed-os-core @ARMmbed/mbed-os-hal @c1728p9 @ithinuel @AnotherButler

It would be good to get eyes on this PR since it's been open for a while.

@AnotherButler
Copy link
Contributor

I'll wait to edit this until some reviews are in and we know the content won't change too much.

Copy link
Member

@ithinuel ithinuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the commentary about i2c_frequency, it looks good to me :)

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 8, 2018

@donatieng do you want to review or anyone else should or happy with the approvals as they are and we can progress with this design document?

@cmonr
Copy link
Contributor

cmonr commented Nov 9, 2018

@AnotherButler It seems that this PR has settled a bit.

@SenRamakri
Copy link
Contributor

@scartmell-arm - Whys is this document under hal, please move this to docs/design-documents/hal, you may create another folder there if you like. This document is not in the prescribed format all other design docs are. Please take a look at - https://github.com/ARMmbed/mbed-os/tree/master/docs/design-documents

@ghost
Copy link
Author

ghost commented Nov 14, 2018

@scartmell-arm - Whys is this document under hal, please move this to docs/design-documents/hal, you may create another folder there if you like. This document is not in the prescribed format all other design docs are. Please take a look at - https://github.com/ARMmbed/mbed-os/tree/master/docs/design-documents

Because it was initially written before either of those were added.

@cmonr
Copy link
Contributor

cmonr commented Dec 19, 2018

@scartmell-arm Any updates?

@ghost
Copy link
Author

ghost commented Dec 20, 2018

@scartmell-arm Any updates?

There were a number of minor changes made to the API after this was written, I'm in the process of updating it to match.

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

@scartmell-arm Are there more updates in the pipeline, or should we start poking reviewers again?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 18, 2019

Is this 5.12 release target? The label is set to it but has not been moved for some time, let us know. In case this is not targeting 5.12, we should remove the 5.12 label.

Copy link
Contributor

@SenRamakri SenRamakri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scartmell-arm - Please follow the design-document template if this needs to be put under docs/design-documents directory - https://github.com/ARMmbed/mbed-os/blob/master/docs/design-documents/design_template.md

@cmonr cmonr added the risk: A label Feb 25, 2019
@bulislaw
Copy link
Member

This PR is at risk of missing 5.12 release as it's marked as "needs: work". Code freeze is coming! On Friday 1st. Please make necessary updates ASAP and make sure the reviewers are aligned for prompt code inspection.

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2019

@scartmell-arm I've been wondering. Don't we have a feature-i2c branch? Shouldn't this be going there instead?

At the current rate, this being on master doesn't seem like it's going to happen before code freeze.

@donatieng
Copy link
Contributor

This should target the feature I2C branch.

@cmonr cmonr changed the base branch from master to feature-i2c February 28, 2019 00:00
@ghost
Copy link
Author

ghost commented Feb 28, 2019

Please follow the design-document template if this needs to be put under docs/design-documents directory

It seems excessive to rewrite the whole design document in that format. Especially when the overhaul in question is primarily just tidying up the function parameters of an existing API.

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2019

@scartmell-arm Are there any available updates on this PR?

@adbridge
Copy link
Contributor

@bulislaw as Steve is leaving, who is taking on the ownership of this PR ?

@bulislaw
Copy link
Member

@ithinuel can you take the ownership?

@cmonr
Copy link
Contributor

cmonr commented Apr 9, 2019

@ithinuel Ping?

@ithinuel
Copy link
Member

Should this be reviewed independently of #10374 ?

@adbridge
Copy link
Contributor

adbridge commented May 1, 2019

@ithinuel any update on this ?

@ithinuel
Copy link
Member

ithinuel commented May 7, 2019

@adbridge I don't remember any answer to my previous question.

@adbridge
Copy link
Contributor

adbridge commented May 7, 2019

Should this be reviewed independently of #10374 ?

@bulislaw can you comment ?

@maciejbocianski
Copy link
Contributor

@donatieng @ithinuel
Work on this document will be continued in #10374
Update for both doc and reference implementation will be available within this week

@bulislaw
Copy link
Member

Thanks @maciejbocianski does it mean we can close this PR?

@maciejbocianski
Copy link
Contributor

Yes please close it. Doc was moved to #10374

@0xc0170 0xc0170 closed this May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.