-
Notifications
You must be signed in to change notification settings - Fork 3k
Add I2C HAL API overhaul design document #7834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mbed-os-core @ARMmbed/mbed-os-hal @c1728p9 @ithinuel @AnotherButler It would be good to get eyes on this PR since it's been open for a while. |
I'll wait to edit this until some reviews are in and we know the content won't change too much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the commentary about i2c_frequency
, it looks good to me :)
- Add return value to i2c_frequency indicating configured frequency. - Change return type of i2c_write/i2c_read from int to int32_t - Add type suffix to i2c_slave_status enum. - Rename i2c_slave_receive to i2c_slave_status.
@donatieng do you want to review or anyone else should or happy with the approvals as they are and we can progress with this design document? |
@AnotherButler It seems that this PR has settled a bit. |
@scartmell-arm - Whys is this document under hal, please move this to docs/design-documents/hal, you may create another folder there if you like. This document is not in the prescribed format all other design docs are. Please take a look at - https://github.com/ARMmbed/mbed-os/tree/master/docs/design-documents |
Because it was initially written before either of those were added. |
@scartmell-arm Any updates? |
There were a number of minor changes made to the API after this was written, I'm in the process of updating it to match. |
@scartmell-arm Are there more updates in the pipeline, or should we start poking reviewers again? |
Is this 5.12 release target? The label is set to it but has not been moved for some time, let us know. In case this is not targeting 5.12, we should remove the 5.12 label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scartmell-arm - Please follow the design-document template if this needs to be put under docs/design-documents directory - https://github.com/ARMmbed/mbed-os/blob/master/docs/design-documents/design_template.md
This PR is at risk of missing 5.12 release as it's marked as "needs: work". Code freeze is coming! On Friday 1st. Please make necessary updates ASAP and make sure the reviewers are aligned for prompt code inspection. |
@scartmell-arm I've been wondering. Don't we have a At the current rate, this being on master doesn't seem like it's going to happen before code freeze. |
This should target the feature I2C branch. |
It seems excessive to rewrite the whole design document in that format. Especially when the overhaul in question is primarily just tidying up the function parameters of an existing API. |
@scartmell-arm Are there any available updates on this PR? |
@bulislaw as Steve is leaving, who is taking on the ownership of this PR ? |
@ithinuel can you take the ownership? |
@ithinuel Ping? |
Should this be reviewed independently of #10374 ? |
@ithinuel any update on this ? |
@donatieng @ithinuel |
Thanks @maciejbocianski does it mean we can close this PR? |
Yes please close it. Doc was moved to #10374 |
Description
This PR adds the Request For Comment document for the I2C HAL API overhaul.
This document is meant to serve as the design document for defining what we plan for the API.
Document readable here.
Pull request type:
@ithinuel @c1728p9