I2c ref impl #10374

maciejbocianski · 2019-04-11T10:13:42Z

Description

This PR is a continuation of the work done in #8682.
It contains all changes from #8682 plus:

hal-i2c slave mode fix for k64f
hal-i2c async mode implementation for k64f
I2CSlave driver adjustment to new HAL I2C API
async implementation in I2C driver

This PR contains reference implementations of the I2C HAL RFC changes for the FRDM-K64F and NUCLEO_F070RB boards.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[X] Breaking change

Reviewers

@ARMmbed/mbed-os-hal

Release Notes

maciejbocianski · 2019-04-11T10:51:41Z

fixing astyle ...done

ciarmcom · 2019-04-11T11:00:28Z

@maciejbocianski, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

maciejbocianski · 2019-04-12T10:21:53Z

Test results of (#9573):

master(NUCLEO_F070RB) - slave(K64F)
+--------------------------------------------------------------+---------+-------------+-------------+--------------------+----------+
| Testcase                                                     | Verdict | Fail Reason | Skip Reason |     platforms      | duration |
+--------------------------------------------------------------+---------+-------------+-------------+--------------------+----------+
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_1B_MIN_FREQUENCY         |   pass  |             |             | NUCLEO_F070RB,K64F |  1.269   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_1B_MAX_FREQUENCY    |   pass  |             |             | NUCLEO_F070RB,K64F |  1.365   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_1025B_MAX_FREQUENCY |   pass  |             |             | NUCLEO_F070RB,K64F |  2.088   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_257B_MAX_FREQUENCY     |   pass  |             |             | NUCLEO_F070RB,K64F |  1.484   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_1B_MIN_FREQUENCY    |   pass  |             |             | NUCLEO_F070RB,K64F |  1.265   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_257B_MIN_FREQUENCY  |   pass  |             |             | NUCLEO_F070RB,K64F |  2.696   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_257B_MAX_FREQUENCY  |   pass  |             |             | NUCLEO_F070RB,K64F |  1.534   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_10B_MIN_FREQUENCY      |   pass  |             |             | NUCLEO_F070RB,K64F |   1.39   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_257B_MAX_FREQUENCY       |   pass  |             |             | NUCLEO_F070RB,K64F |   1.48   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_10B_MAX_FREQUENCY      |   pass  |             |             | NUCLEO_F070RB,K64F |  1.269   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_1025B_MAX_FREQUENCY      |   pass  |             |             | NUCLEO_F070RB,K64F |   2.12   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_257B_MIN_FREQUENCY       |   pass  |             |             | NUCLEO_F070RB,K64F |  2.825   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_1B_MAX_FREQUENCY         |   pass  |             |             | NUCLEO_F070RB,K64F |  1.124   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_10B_MAX_FREQUENCY   |   pass  |             |             | NUCLEO_F070RB,K64F |  1.204   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_10B_MIN_FREQUENCY        |   pass  |             |             | NUCLEO_F070RB,K64F |  1.299   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_10B_MIN_FREQUENCY   |   pass  |             |             | NUCLEO_F070RB,K64F |  1.355   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_10B_MAX_FREQUENCY        |   pass  |             |             | NUCLEO_F070RB,K64F |  1.249   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_1B_MAX_FREQUENCY       |   pass  |             |             | NUCLEO_F070RB,K64F |  1.236   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_1B_MIN_FREQUENCY       |   pass  |             |             | NUCLEO_F070RB,K64F |   1.21   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_257B_MIN_FREQUENCY     |   pass  |             |             | NUCLEO_F070RB,K64F |  2.775   |
+--------------------------------------------------------------+---------+-------------+-------------+--------------------+----------+

master(K64F) - slave(NUCLEO_F070RB)
+--------------------------------------------------------------+---------+-------------+-------------+--------------------+----------+
| Testcase                                                     | Verdict | Fail Reason | Skip Reason |     platforms      | duration |
+--------------------------------------------------------------+---------+-------------+-------------+--------------------+----------+
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_1B_MIN_FREQUENCY         |   pass  |             |             | K64F,NUCLEO_F070RB |  1.254   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_1B_MAX_FREQUENCY    |   pass  |             |             | K64F,NUCLEO_F070RB |  1.301   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_1025B_MAX_FREQUENCY |   pass  |             |             | K64F,NUCLEO_F070RB |  1.865   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_257B_MAX_FREQUENCY     |   pass  |             |             | K64F,NUCLEO_F070RB |  1.475   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_1B_MIN_FREQUENCY    |   pass  |             |             | K64F,NUCLEO_F070RB |  1.236   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_257B_MIN_FREQUENCY  |   pass  |             |             | K64F,NUCLEO_F070RB |  2.827   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_257B_MAX_FREQUENCY  |   pass  |             |             | K64F,NUCLEO_F070RB |  1.553   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_10B_MIN_FREQUENCY      |   pass  |             |             | K64F,NUCLEO_F070RB |  1.341   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_257B_MAX_FREQUENCY       |   pass  |             |             | K64F,NUCLEO_F070RB |  1.576   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_10B_MAX_FREQUENCY      |   pass  |             |             | K64F,NUCLEO_F070RB |  1.203   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_1025B_MAX_FREQUENCY      |   pass  |             |             | K64F,NUCLEO_F070RB |  1.916   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_257B_MIN_FREQUENCY       |   pass  |             |             | K64F,NUCLEO_F070RB |  2.699   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_1B_MAX_FREQUENCY         |   pass  |             |             | K64F,NUCLEO_F070RB |  1.184   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_10B_MAX_FREQUENCY   |   pass  |             |             | K64F,NUCLEO_F070RB |  1.277   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_10B_MIN_FREQUENCY        |   pass  |             |             | K64F,NUCLEO_F070RB |  1.342   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_10B_MIN_FREQUENCY   |   pass  |             |             | K64F,NUCLEO_F070RB |  1.321   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_10B_MAX_FREQUENCY        |   pass  |             |             | K64F,NUCLEO_F070RB |  1.274   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_1B_MAX_FREQUENCY       |   pass  |             |             | K64F,NUCLEO_F070RB |  1.244   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_1B_MIN_FREQUENCY       |   pass  |             |             | K64F,NUCLEO_F070RB |  1.219   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_257B_MIN_FREQUENCY     |   pass  |             |             | K64F,NUCLEO_F070RB |   2.68   |
+--------------------------------------------------------------+---------+-------------+-------------+--------------------+----------+

master(K64F) - slave(K64F)
+--------------------------------------------------------------+---------+-------------+-------------+-----------+----------+
| Testcase                                                     | Verdict | Fail Reason | Skip Reason | platforms | duration |
+--------------------------------------------------------------+---------+-------------+-------------+-----------+----------+
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_1B_MIN_FREQUENCY         |   pass  |             |             |    K64F   |  1.241   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_1B_MAX_FREQUENCY    |   pass  |             |             |    K64F   |  1.195   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_1025B_MAX_FREQUENCY |   pass  |             |             |    K64F   |  1.891   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_257B_MAX_FREQUENCY     |   pass  |             |             |    K64F   |  1.426   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_1B_MIN_FREQUENCY    |   pass  |             |             |    K64F   |  1.256   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_257B_MIN_FREQUENCY  |   pass  |             |             |    K64F   |  2.564   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_257B_MAX_FREQUENCY  |   pass  |             |             |    K64F   |  1.459   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_10B_MIN_FREQUENCY      |   pass  |             |             |    K64F   |  1.332   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_257B_MAX_FREQUENCY       |   pass  |             |             |    K64F   |  1.497   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_10B_MAX_FREQUENCY      |   pass  |             |             |    K64F   |  1.218   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_1025B_MAX_FREQUENCY      |   pass  |             |             |    K64F   |   2.01   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_257B_MIN_FREQUENCY       |   pass  |             |             |    K64F   |  2.674   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_1B_MAX_FREQUENCY         |   pass  |             |             |    K64F   |  1.239   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_10B_MAX_FREQUENCY   |   pass  |             |             |    K64F   |  1.211   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_10B_MIN_FREQUENCY        |   pass  |             |             |    K64F   |  1.296   |
| I2C_COM_MASTER-SLAVE_BLOCKING_WRITE-READ_10B_MIN_FREQUENCY   |   pass  |             |             |    K64F   |  1.351   |
| I2C_COM_MASTER-SLAVE_ASYNC_TRANSFER_10B_MAX_FREQUENCY        |   pass  |             |             |    K64F   |  1.185   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_1B_MAX_FREQUENCY       |   pass  |             |             |    K64F   |  1.271   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_1B_MIN_FREQUENCY       |   pass  |             |             |    K64F   |  1.278   |
| I2C_COM_MASTER-SLAVE_ASYNC_WRITE-READ_257B_MIN_FREQUENCY     |   pass  |             |             |    K64F   |   2.7    |
+--------------------------------------------------------------+---------+-------------+-------------+-----------+----------+

ithinuel · 2019-04-12T11:04:47Z

Under review

ithinuel

There are inconsistencies on address' maximum lenght (9/10bits)
The API snippet of the design doc is inconsistent with the statements made before (eg. stop argument to i2c_read and i2c_write).
Why Async has a single "transfer" while sync has "read" and "write" ?
What is the other of read/write operations in Async ?
How the device is expected to process an abort of the transfer ?
- Should it send a stop if one was requested ?
  - Are symbols atomic ? That is to say, should the transfer stop in the middle of a transmission when abort is called or should it gracefully stop after the current symbol ?
  - Is an abort considered an error and should it be reported as such in the event ?
  - Is the event callback invoked at all in case of abort ?

There are also typos here and there but they're minor issues in regards to the comment above & in the code.

I have not reviewed (yet) the implementations as I don't know (yet) the platform, my feedback on these would not be very deep. And the API should probably be fixed before we give attention to the details of the implementations.

targets/targets.json

drivers/I2C.cpp

ithinuel · 2019-04-12T12:36:16Z

drivers/I2C.cpp

 I2C *I2C::_owner = NULL;
 SingletonPtr<PlatformMutex> I2C::_mutex;

 I2C::I2C(PinName sda, PinName scl) :


This implementation does not seem to deal with multiple i2c peripheral used in parallel very well.

Only 1 I2C can be used at a time.

There is no mechanism that I can see that prevent an i²c peripheral to be instantiated twice.

The I2C class seem to be oriented to have 1 instance per bus instead of 1 instance per slave like SPI class does.
This is probably out of the scope of this PR as it'd create breaking change on the C++ API level but it is still worth nothing that this is inconsistent and should be fixed.

I agree the improvement of I2C and I2CSlave drivers should be in separate PR. This PR should include only adaptation to HAL API changes

Yes, adding extra functionality to the driver is out of scope

docs/design-documents/hal/0001-i2c-overhaul.md

ithinuel · 2019-04-12T13:52:15Z

docs/design-documents/hal/0001-i2c-overhaul.md

+
+  Currently the `DMAUsage` argument of the `i2c_transfer_asynch` function is unimplemented, the argument is unused by all `I2C` implementations. There is no real demand for it so can be removed from the API.
+
+- **Change** the `stop` parameter from the `i2c_transfer_async` from an `uint32_t` to a `bool`.


Why isn't this argument removed Since it is also removed from the sync API ?

Actually stop stays for both sync and async API

hal/i2c_api.h

ithinuel · 2019-04-12T14:31:36Z

hal/i2c_api.h

 *  @param data    The buffer for sending
 *  @param length  Number of bytes to write
- *  @param stop    Stop to be generated after the transfer is done
+ *  @param stop    If true, stop will be generated after the transfer is done


Shouldn't this be removed from the parameter list as per the design doc ?

stop stays

hal/i2c_api.h

mbed-ci · 2019-04-16T19:19:17Z

Test run: FAILED

Summary: 5 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_mbed2-build-IAR

adbridge · 2019-04-26T12:43:15Z

@ithinuel Could you please re-review?

0xc0170 · 2019-05-03T13:06:43Z

@ithinuel @maciejbocianski Any update? Is there anyone else who could review?

maciejbocianski · 2019-05-07T12:37:36Z

Update for both doc and reference implementation will be available within this week

maciejbocianski · 2019-05-10T07:31:09Z

@ithinuel

typos has been fixed
API header file/design doc inconsistencies has been fixed
single ASYNC transfer function was inherited from old API and also I2C driver has single ASYNC transfer function. But actually I don't see the advantage of such API over two separata write/read function . Anyway, single ASYNC transfer function works as write and then read done one after the other. So it would be easily replaced by two functions
I can see that at abort sends stop signal unconditionally (at least STM and freescale SDK implementations does)
I2C uses byte transfer (symbol == one byte) and each byte is confirmed so single byte send is atomic
calling i2c_abort_async disables async callback mechanism

adbridge · 2019-05-17T08:43:34Z

@ithinuel could you re-review this please

jamesbeyond

I am happy about the changes

maciejbocianski · 2019-05-23T06:45:59Z

@ithinuel
after review changes:

i2c structure update
timeout functionality update
doc fixes/update

maciejbocianski · 2019-06-25T11:44:21Z

rebased

0xc0170 · 2019-06-25T12:27:05Z

CI started

mbed-ci · 2019-06-25T18:55:19Z

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_mbed2-build-ARM
jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_mbed2-build-IAR
jenkins-ci/mbed-os-ci_build-ARM

0xc0170 · 2019-06-26T08:07:56Z

Please review build failures, related

…low I2C-less builds

I2CName should stay when I2C is disabled, becouse it's required by PeripheralPins.c

maciejbocianski · 2019-06-26T11:33:42Z

Fixes for specific errors were provided
Can we rerun CI to check if mbed-os-example-mesh-minima and nanostack-border-router still fail (locally on my PC both succeeded)

0xc0170 · 2019-06-26T11:36:47Z

CI restarted

mbed-ci · 2019-06-26T12:46:53Z

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

0xc0170 · 2019-06-26T13:36:36Z

restarted

mbed-ci · 2019-06-26T17:07:16Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 7
Build artifacts

AnotherButler · 2019-07-05T15:24:04Z

Can someone please review ARMmbed/mbed-os-5-docs#807 to make sure it's up to date?

ciarmcom requested a review from a team April 11, 2019 11:00

ciarmcom added the needs: review label Apr 11, 2019

0xc0170 added the release-version: feature branch label Apr 11, 2019

cmonr requested a review from a team April 12, 2019 00:03

cmonr mentioned this pull request Apr 12, 2019

RFC HAL I2C: Reference implementations for K64F and STM32F0 #8682

Closed

5 tasks

maciejbocianski force-pushed the i2c_ref_impl branch from 00a81f2 to 76e4118 Compare April 12, 2019 10:41

0xc0170 mentioned this pull request Apr 12, 2019

Add CI i2c hal test #9564

Closed

ithinuel suggested changes Apr 12, 2019

View reviewed changes

ithinuel mentioned this pull request Apr 12, 2019

Add I2C HAL API overhaul design document #7834

Closed

0xc0170 added needs: work and removed needs: review labels Apr 15, 2019

maciejbocianski force-pushed the i2c_ref_impl branch 2 times, most recently from 86d4949 to 7b639bd Compare April 17, 2019 13:11

AnotherButler mentioned this pull request Apr 18, 2019

Add porting guide for HAL I2C API ARMmbed/mbed-os-5-docs#807

Closed

adbridge added needs: review and removed needs: work labels Apr 26, 2019

jamesbeyond approved these changes May 21, 2019

View reviewed changes

maciejbocianski force-pushed the i2c_ref_impl branch 2 times, most recently from d775f47 to 86c5f6c Compare May 27, 2019 13:07

maciejbocianski added 2 commits June 25, 2019 13:28

Driver i2c: update timeout documentation

3618415

Driver i2c: improve frequency setting function

78f6426

maciejbocianski force-pushed the i2c_ref_impl branch from 39c53c0 to 78f6426 Compare June 25, 2019 11:43

0xc0170 added needs: CI and removed needs: work labels Jun 25, 2019

0xc0170 added needs: work and removed needs: CI labels Jun 26, 2019

maciejbocianski added 5 commits June 26, 2019 11:47

LPC408X: temporarily disable ETHERNET API to allow I2C-less builds

76d8f32

UBLOX_C030: temporarily disable I2C API and min_battery_voltage to al…

da0a28a

…low I2C-less builds

EFM32: remove DEVICE_I2C guard from I2CName

4eb29bc

I2CName should stay when I2C is disabled, becouse it's required by PeripheralPins.c

STM32WB: fix i2c_s struct

f6c50ec

STM32H7: fix i2c_s struct

6065cd1

GR_LYCHEE: temporarily disable TRNG since it uses I2C

28d8766

maciejbocianski force-pushed the i2c_ref_impl branch from 117cfc1 to 28d8766 Compare June 26, 2019 13:24

Disable examples unsupported on i2c feature branch.

9fd7870

0xc0170 added ready for merge and removed needs: work labels Jun 27, 2019

0xc0170 approved these changes Jun 28, 2019

View reviewed changes

0xc0170 merged commit 42cafe6 into ARMmbed:feature-i2c Jun 28, 2019

0xc0170 removed the ready for merge label Jun 28, 2019


		Currently the `DMAUsage` argument of the `i2c_transfer_asynch` function is unimplemented, the argument is unused by all `I2C` implementations. There is no real demand for it so can be removed from the API.

		- Change the `stop` parameter from the `i2c_transfer_async` from an `uint32_t` to a `bool`.

I2c ref impl #10374

I2c ref impl #10374

Uh oh!

Conversation

maciejbocianski commented Apr 11, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

maciejbocianski commented Apr 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ciarmcom commented Apr 11, 2019

Uh oh!

maciejbocianski commented Apr 12, 2019

Uh oh!

ithinuel commented Apr 12, 2019

Uh oh!

ithinuel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mbed-ci commented Apr 16, 2019

Uh oh!

adbridge commented Apr 26, 2019

Uh oh!

0xc0170 commented May 3, 2019

Uh oh!

maciejbocianski commented May 7, 2019

Uh oh!

maciejbocianski commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adbridge commented May 17, 2019

Uh oh!

jamesbeyond left a comment

Choose a reason for hiding this comment

Uh oh!

maciejbocianski commented May 23, 2019

Uh oh!

maciejbocianski commented Jun 25, 2019

Uh oh!

0xc0170 commented Jun 25, 2019

Uh oh!

mbed-ci commented Jun 25, 2019

Uh oh!

0xc0170 commented Jun 26, 2019

Uh oh!

maciejbocianski commented Jun 26, 2019

Uh oh!

0xc0170 commented Jun 26, 2019

Uh oh!

mbed-ci commented Jun 26, 2019

Uh oh!

0xc0170 commented Jun 26, 2019

Uh oh!

mbed-ci commented Jun 26, 2019

Uh oh!

AnotherButler commented Jul 5, 2019

maciejbocianski commented Apr 11, 2019 •

edited

Loading

maciejbocianski commented May 10, 2019 •

edited

Loading