Skip to content

Add Ice Tea I2C communication test #9573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add Ice Tea I2C communication test #9573

wants to merge 3 commits into from

Conversation

maciejbocianski
Copy link
Contributor

Description

Provide I2C communication test which uses IceTea Framework.
Detailed description can be found in README.md file in the test case folder.

This PR depends on #8682

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@scartmell-arm
@ARMmbed/mbed-os-hal

@ciarmcom ciarmcom requested review from a user January 31, 2019 16:00
@ciarmcom
Copy link
Member

@maciejbocianski, thank you for your changes.
@scartmell-arm @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 13, 2019

@scartmell-arm Please review

@maciejbocianski maciejbocianski force-pushed the i2c_communication_test_pr branch 3 times, most recently from f1b1f49 to e1350f7 Compare March 7, 2019 12:52
@maciejbocianski maciejbocianski mentioned this pull request Mar 27, 2019
Closed
5 tasks
@maciejbocianski maciejbocianski force-pushed the i2c_communication_test_pr branch 3 times, most recently from f5d4ef3 to d9b5a93 Compare April 11, 2019 11:02
@maciejbocianski maciejbocianski mentioned this pull request Apr 12, 2019
Merged
5 tasks
@maciejbocianski maciejbocianski force-pushed the i2c_communication_test_pr branch from d9b5a93 to 1e31ff2 Compare April 12, 2019 10:33
@mbed-ci
Copy link

mbed-ci commented Apr 16, 2019

Test run: SUCCESS

Summary: 1 of 1 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 requested review from a team and removed request for a user April 16, 2019 08:31
@maciejbocianski
Copy link
Contributor Author

Test has been updated:

  • sync with HAL I2C API changes
  • add stop signal configuration
  • add timeout functionality
  • update testcases
  • warning fixes

@adbridge
Copy link
Contributor

@ithinuel @c1728p9 could one of you please re-review this ?

@maciejbocianski
Copy link
Contributor Author

heap memory optimization has been added

@adbridge
Copy link
Contributor

@maciejbocianski does this now depend on #10374 ?

@maciejbocianski
Copy link
Contributor Author

Yes it does

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

@maciejbocianski Shall we proceed here or close?

@maciejbocianski
Add Ice Tea I2C communication test
ca902d0
@maciejbocianski
i2c communication test update
7c6ec9c 
 - sync with HAL I2C API changes
 - add stop signal configuration
 - add timeout functionality
 - update testcases
@maciejbocianski
i2c communication test: heap memory usage optimization
dca2370 
use stack memory for data buffers
@maciejbocianski maciejbocianski force-pushed the i2c_communication_test_pr branch from 3433e5e to dca2370 Compare July 9, 2019 11:44
@SeppoTakalo
Copy link
Contributor

It is unclear for me what should be done with this PR. Please update the status, or close.
This is already many months old, and test results are older than the current state of the branch.

@maciejbocianski
Copy link
Contributor Author

Frankly both test #9573 and #9564 are being replaced by fpga-ci-test-shield ones https://github.com/ARMmbed/mbed-os/tree/master/TESTS/mbed_hal_fpga_ci_test_shield
I think @jamesbeyond should decide what to do with these PRs

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

I think @jamesbeyond should decide what to do with these PRs

@jamesbeyond Please review above comment and let us know

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 5, 2019

@jamesbeyond I'll close this one as "won't fix".

@0xc0170 0xc0170 closed this Sep 5, 2019
@jamesbeyond
Copy link
Contributor

@maciejbocianski @0xc0170 Thanks for updating this ticket,.
As the Icetea is going to be deprecated in short future, we'll not merge these tests into mbed-os. the contents of the test already been covered by the FPGA shield tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@c1728p9 c1728p9 c1728p9 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs: work release-version: feature branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@maciejbocianski @ciarmcom @0xc0170 @mbed-ci @adbridge @SeppoTakalo @jamesbeyond @c1728p9 @cmonr