Skip to content

Added some E5 board + Fixes #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

Added some E5 board + Fixes #13

wants to merge 19 commits into from

Conversation

hallard
Copy link
Contributor

@hallard hallard commented Jul 19, 2021

  • Fixed console port on RAK3172
  • fixed misnamed RAK7231_radio_driver to RAK3172_radio_driver
  • fixed button 1 mapping

@hallard hallard mentioned this pull request Jul 20, 2021
Merged
jeromecoutant
jeromecoutant reviewed Jul 20, 2021
View reviewed changes
README.md Outdated
Comment on lines 94 to 101
LoRa-E5 use only RFO_HP so you need to add this to your `mbed_app.json` on section `target_overrides`

```json

"LORA_E5": {
"stm32wl-lora-driver.rf_switch_config": 2
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to "Seeed Studio LoRa E5" ?

README.md Outdated
Comment on lines 140 to 143
"RAK3172": {
"stm32wl-lora-driver.rf_switch_config": 2,
"stm32wl-lora-driver.crystal_select" : 0
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment, move this part above ?

TARGET_STM32WL/CMakeLists.txt
Comment on lines +6 to +7
add_subdirectory(TARGET_LORA_E5_MINI EXCLUDE_FROM_ALL)
add_subdirectory(TARGET_LORA_E5_DEV_BOARD EXCLUDE_FROM_ALL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new targets are not in the readme

@hallard hallard requested a review from jeromecoutant July 20, 2021 07:55
@hallard
Copy link
Contributor Author

hallard commented Jul 20, 2021

All requested changes done

@jeromecoutant
Copy link
Contributor

Mmm,I know you love git commands...
But, same rule as in mbed-os repo, merge commit is not allowed.
Could you rebase your commits on top of master, and force push again to this PR ? Thx

jeromecoutant
jeromecoutant reviewed Jul 21, 2021
View reviewed changes
README.md
## Seeed Studio LoRa E5 Mini

Use LoRa E5 modulen basic board with USB/Serial and headers

Copy link
Contributor

@jeromecoutant jeromecoutant Jul 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see for other targets, I added, for each one, some information to match this doc file with the json file.
Which target should I build for this target ?

Thx

TARGET: XXX

See https://github.com/ARMmbed/stm32customtargets#manual-pull-request-checks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I updated readme with:

  • LORA_E5_DEV_BOARD
  • LORA_E5_MINI

@jeromecoutant
Copy link
Contributor

jeromecoutant commented Jul 21, 2021 •
edited
Loading

I am sorry, last commit is a merge one...
Could you rebase your commits on top of master, and force push again to this PR ?
(clean branch starting from origin/master)
Thx

jeromecoutant
jeromecoutant requested changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for a clean branch

@hallard
Copy link
Contributor Author

hallard commented Jul 21, 2021

I am sorry, last commit is a merge one...
Could you rebase your commits on top of master, and force push again to this PR ?
(clean branch starting from origin/master)
Thx

humm, I'm very sorry sometimes git is equal to some magic for me. I merged upstream/master (your repo) into my master repos (the one I forked from you), then I also merged upstream/master into this branch E5_DevBoardswhich contains these changes. so for me it's up to date with master and contains only changes, but my be I'm missing something.

It looks like it's confirmed by git client, rebase from origin/master is not possible because it's already up to date

image

and from upstream/master either
image

Do I miss something? I can also close this PR, save my files, create new clean branch/new PR with saved file if you're more confortable with that. Just let me know.

@hallard hallard mentioned this pull request Jul 21, 2021
Merged
@hallard
Copy link
Contributor Author

hallard commented Jul 21, 2021

replaced by clean #15

@hallard hallard closed this Jul 21, 2021
@jeromecoutant jeromecoutant mentioned this pull request Jul 21, 2021
Merged
@hallard hallard deleted the E5_DevBoard branch July 21, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeromecoutant jeromecoutant jeromecoutant requested changes

Assignees

No one assigned

Labels

LORA STM32WL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hallard @jeromecoutant