qcoverage - change jaxb jars to prepare for newer java versions #338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
qcoverageusesJAXBfor the serialisation of java objects into an xml report. The jar files that theJAXBimplementation depends on are housed within java'srt.jarin versions of java up to version 8. Version 9 and 10 contain the relevant jar files, but they have been deprecated, and from version 11 onwards, they have been removed.More info here.
If you run the current released
qcoveragecode (/software/adamajava/adamajava-release/123.cdccef6/) using java 11, aClassNotFoundExceptionis thrown.Unfortunately, the simple fix of adding the
JAXBdependancies didn't work, due to ClassLoader issues, and so the simplest way I could find to fix this was to use theJAXBimplementation fromeclipse, called MOXy.The build file was amended to bring in the
jakartaJAXB bindings jar, along with theMOXyjar.The model classes (
QCoverageSpec,CoverageModelandCoverageReport) were refactored to import from the different dependencies and tests were added.Type of change
Refactoring to ready the codebase for newer java versions
How Has This Been Tested?
Additional tests have been added and the updated code has been run against a bam and the results favourably compared with the previous versions reults.
Are WDL Updates Required?
n/a
Checklist: