Skip to content

Conversation

@holmeso
Copy link
Contributor

@holmeso holmeso commented Nov 3, 2023

Description

It's time to update adamajava (AJ) to java 21 (it has been on 1.8 for a long time).
There are numerous advantages that the reader can easily find out for themselves.

The following changes were made to the AJ codebase to enable this change

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Existing unit tests have been updated to pass,

Are WDL Updates Required?

Yes. Once an AJ release is performed, any wdl wanting to take advantage of the new release will need to swap out all "module load java/1.8..." commands with the 21 equivalent

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@delocalizer delocalizer self-assigned this Nov 6, 2023
Copy link
Contributor

@delocalizer delocalizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing us into the 2020s!

@holmeso holmeso merged commit 5a5c3b7 into master Nov 20, 2023
@holmeso holmeso deleted the java21 branch November 20, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants