Skip to content

types(schema): correctly infer Array<Schema.Types.*> #14534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2024
Merged

types(schema): correctly infer Array<Schema.Types.*> #14534

merged 1 commit into from
Apr 29, 2024

Conversation

@vkarpov15
Copy link
Collaborator

Re: #14367

Summary

Part of the issue in this comment is that we don't infer correct type in TypeScript when user uses path: [Schema.Types.String] to define an array of strings.

Examples

@vkarpov15 vkarpov15 mentioned this pull request Apr 24, 2024
Closed
2 tasks
@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Apr 25, 2024
@vkarpov15 vkarpov15 added this to the 8.3.3 milestone Apr 29, 2024
@vkarpov15 vkarpov15 merged commit af2afc1 into master Apr 29, 2024
@hasezoey hasezoey deleted the vkarpov15/gh-14367-2 branch April 30, 2024 11:28
@Gabo-Tech Gabo-Tech mentioned this pull request May 20, 2024
Open
@lholmquist lholmquist mentioned this pull request May 20, 2024
Closed
@James220903 James220903 mentioned this pull request May 20, 2024
Open
@Erenkrs Erenkrs mentioned this pull request May 20, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 20, 2024
Open
@tomlebl tomlebl mentioned this pull request May 21, 2024
Closed
@carltrepanier carltrepanier mentioned this pull request May 21, 2024
Merged
@OOCAZ OOCAZ mentioned this pull request May 21, 2024
Merged
This was referenced May 21, 2024
Merged
Merged
This was referenced May 21, 2024
Merged
Merged
@MihikaNigam MihikaNigam mentioned this pull request May 21, 2024
Open
@solitariusdigital solitariusdigital mentioned this pull request May 21, 2024
Closed
@akanchhaS akanchhaS mentioned this pull request May 21, 2024
Open
@adriaaaann adriaaaann mentioned this pull request May 21, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request May 21, 2024
Open
This was referenced May 21, 2024
Merged
Merged
@tuanicom tuanicom mentioned this pull request May 21, 2024
Merged
@Proushoth Proushoth mentioned this pull request May 21, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jun 6, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 6, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Jun 7, 2024
Open
@lholmquist lholmquist mentioned this pull request Jun 7, 2024
Closed
@NotZarifGithub NotZarifGithub mentioned this pull request Jun 7, 2024
Open
This was referenced Jun 7, 2024
Open
Open
@akanchhaS akanchhaS mentioned this pull request Jun 8, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Jun 8, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 8, 2024
Open
@DulranS DulranS mentioned this pull request Jun 8, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Jun 8, 2024
Open
@mihirhbhatt mihirhbhatt mentioned this pull request Jun 8, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jun 8, 2024
Open
@astitva3110 astitva3110 mentioned this pull request Jun 8, 2024
Open
This was referenced Jun 9, 2024
Open
Open
@koha2006-hue koha2006-hue mentioned this pull request Jun 12, 2024
Open
This was referenced Jun 12, 2024
Open
Open
@Mekdeskebede Mekdeskebede mentioned this pull request Jun 13, 2024
Open
@Rayadi-Ayoub Rayadi-Ayoub mentioned this pull request Jun 14, 2024
Open
@MinhhTien MinhhTien mentioned this pull request Jun 14, 2024
Closed
@slur96 slur96 mentioned this pull request Jun 14, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 15, 2024
Open
@global-tek global-tek mentioned this pull request Jun 15, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 16, 2024
Open
@malinanu malinanu mentioned this pull request Jun 16, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 16, 2024
Open
@ashiq-firoz ashiq-firoz mentioned this pull request Jun 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees

No one assigned

Labels

typescript Types or Types-test related issue / Pull Request

Projects

None yet

Milestone

8.3.3

Development

Successfully merging this pull request may close these issues.

2 participants

@vkarpov15 @hasezoey