Skip to content

types(schema): correctly infer Array<Schema.Types.*> #14534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2024
Merged

types(schema): correctly infer Array<Schema.Types.*> #14534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions test/types/schema.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1424,3 +1424,21 @@ function gh14496() {
}
});
}

function gh14367() {
const UserSchema = new Schema({
counts: [Schema.Types.Number],
roles: [Schema.Types.String],
dates: [Schema.Types.Date],
flags: [Schema.Types.Boolean]
});

type IUser = InferSchemaType<typeof UserSchema>;

const x: IUser = {
counts: [12],
roles: ['test'],
dates: [new Date('2016-06-01')],
flags: [true]
};
}
22 changes: 17 additions & 5 deletions types/inferschematype.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,15 +198,27 @@ type IsSchemaTypeFromBuiltinClass<T> = T extends (typeof String)
? true
: T extends (typeof Schema.Types.Decimal128)
? true
: T extends Types.ObjectId
: T extends (typeof Schema.Types.String)
? true
: T extends Types.Decimal128
: T extends (typeof Schema.Types.Number)
? true
: T extends Buffer
: T extends (typeof Schema.Types.Date)
? true
: T extends (typeof Schema.Types.Mixed)
: T extends (typeof Schema.Types.Boolean)
? true
: IfEquals<T, Schema.Types.ObjectId, true, false>;
: T extends (typeof Schema.Types.Buffer)
? true
: T extends Types.ObjectId
? true
: T extends Types.Decimal128
? true
: T extends Buffer
? true
: T extends NativeDate
? true
: T extends (typeof Schema.Types.Mixed)
? true
: IfEquals<T, Schema.Types.ObjectId, true, false>;

/**
* @summary Resolve path type by returning the corresponding type.
Expand Down