feat(mongoose): allow drivers to set global plugins #14682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
approved these changes
Jun 24, 2024
This was referenced Jul 30, 2024
This was referenced Jul 30, 2024
This was referenced Aug 2, 2024
This was referenced Aug 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
One thing that's unfortunately missing from the driver API is the ability to set global plugins. Drivers can always do
mongoose.plugin(myPlugin), but the problem is that assumes you only have one Mongoose instance. If a user were to doconst mongoose = new Mongoose(); mongoose.setDriver(myDriver);, then there's no way for that driver to apply plugins to the new Mongoose instance.With this PR, drivers can export a
pluginsarray thatsetDriver()will look for, and apply plugins to the Mongoose instance.Examples