-
-
Couldn't load subscription status.
- Fork 3.9k
8.5 #14729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types(models+query): infer return type from schema for 1-level deep nested paths
Co-authored-by: hasezoey <[email protected]>
types(connection): make transaction() return type match the executor function
…defaultoptions perf: memoize toJSON / toObject default options
… false after Mongoose instance created re: #8302
…deleting initial connection Re: #8302
…tion if `monitorCommands` option set Fix #14611
feat(connection): bubble up monitorCommands events to Mongoose connection if `monitorCommands` option set
…ode review comments Re: #8302
Co-authored-by: hasezoey <[email protected]>
Remove default connection if setting createInitialConnection to false after Mongoose instance created
feat(mongoose): allow drivers to set global plugins
…lected in the schema
…edPathsSnapshot()`, `$clearModifiedPaths()` Fix #14268
fix(query): remove `count()` and `findOneAndRemove()` from query chaining
feat(query): make sanitizeProjection prevent projecting in paths deselected in the schema
Co-authored-by: hasezoey <[email protected]>
Co-authored-by: hasezoey <[email protected]>
Co-authored-by: hasezoey <[email protected]>
feat(document): add `$createModifiedPathsSnapshot()`, `$restoreModifiedPathsSnapshot()`, `$clearModifiedPaths()`
feat: allow setting array default value to `null`
hasezoey
requested changes
Jul 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the new test failures, the code looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Examples