Add retry policy support for worker-indexing scenarios #9265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
satvu
force-pushed
the
satvu/retry-options
branch
from
9efa002 to
dc9592e
Compare
kshyju
reviewed
May 23, 2023
src/WebJobs.Script.Grpc/MessageExtensions/GrpcMessageConversionExtensions.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.Grpc/MessageExtensions/GrpcMessageConversionExtensions.cs
Outdated
Show resolved
Hide resolved
| // populate retry options if json string representation is provided | ||
| if (!string.IsNullOrEmpty(rawFunction.RetryOptions)) | ||
| { | ||
| function.Retry = JObject.Parse(rawFunction.RetryOptions).ToObject<RetryOptions>(); |
Member
There was a problem hiding this comment.
Oh, we still have the Json string for the retry option data ? I See this is existing code. Are we planning to make this prop obsolete and recommend language owners to use the strongly typed version (The new property we recently added to proto file)?
Member
Author
There was a problem hiding this comment.
The strongly typed version added here is only for worker-indexing scenarios - I'm not sure if host indexing (or other providers like extension loader or custom providers from partner services) are still using the legacy bits.
kshyju
approved these changes
May 23, 2023
satvu
commented
May 23, 2023
| if (!retryOptions.MinimumInterval.HasValue) | ||
| { | ||
| throw new ArgumentNullException(nameof(retryOptions.DelayInterval)); | ||
| throw new ArgumentNullException(nameof(retryOptions.MinimumInterval)); |
Member
Author
There was a problem hiding this comment.
@kshyju thanks to your suggestion of testing the error message :) found a bug
liliankasem
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #9104
Pull request checklist
release_notes.mdAdditional information
Depends on #94 in the protobuf repo.