-
Notifications
You must be signed in to change notification settings - Fork 473
Add retry policy support for worker-indexing scenarios #9265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
723de40
add raw retry field for testing/prototyping
satvu e092404
duration fix
satvu 7a71d6f
retry startegy added
satvu 48fcd8a
updates
satvu 09adf43
refactor validation, update message names
satvu dbf3990
cleanup
satvu dc9592e
add tests for retry validation
satvu fca4fc6
resolve comments, fix tests and utility bug
satvu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -912,11 +912,11 @@ public static void ValidateRetryOptions(RetryOptions | |
| case RetryStrategy.ExponentialBackoff: | ||
| if (!retryOptions.MinimumInterval.HasValue) | ||
| { | ||
| throw new ArgumentNullException(nameof(retryOptions.DelayInterval)); | ||
| throw new ArgumentNullException(nameof(retryOptions.MinimumInterval)); | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kshyju thanks to your suggestion of testing the error message :) found a bug |
||
| } | ||
| if (!retryOptions.MaximumInterval.HasValue) | ||
| { | ||
| throw new ArgumentNullException(nameof(retryOptions.DelayInterval)); | ||
| throw new ArgumentNullException(nameof(retryOptions.MaximumInterval)); | ||
| } | ||
| // ensure values specified to create ExponentialBackoffRetryAttribute are valid | ||
| _ = new ExponentialBackoffRetryAttribute(retryOptions.MaxRetryCount.Value, retryOptions.MinimumInterval.ToString(), retryOptions.MaximumInterval.ToString()); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, we still have the Json string for the retry option data ? I See this is existing code. Are we planning to make this prop obsolete and recommend language owners to use the strongly typed version (The new property we recently added to proto file)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strongly typed version added here is only for worker-indexing scenarios - I'm not sure if host indexing (or other providers like extension loader or custom providers from partner services) are still using the legacy bits.