Skip to content

Conversation

@BethanyZhou
Copy link
Contributor

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

BethanyZhou and others added 30 commits February 8, 2023 15:02
* add pipeline yml for syncing fabricbot.json aliases

* change git user name and email in script

* change inline script to GetWiki2Json.ps1 file

* remove unnecessary code

* change wrong dir

* change to my personal repo for test

* change the usage of token

* change CreatePR.ps1 for test

* correct ParseWiki2Json.ps1

* remove unnecessary output

* remove quote

* finish test, change back to Azure repo

* change branch name

* change some names

* remove the use of magic number

* change commit message

* remove redundant git pull

* change the way of getting wiki content

* change space to -

* add md

* set current dir

* use space

* use -

* still use ADOToken

* use a better wiki url

* test purpose

* test2

* test oauth

* test3

* finish test

* test again

* test

* finish  test

* test cron

* test double pr

* solve double pr

* test

* test

* test

* finish test

* test

* finish test

* test restapi

* te

* finish test

* test

* finish test

* filter pr

* test

* test

* test

* test

* finish test

---------

Co-authored-by: Hongtu Zhang (FA Talent) <[email protected]>
* Added cmdlets for policy attestations

* Addressed pipeline errors

* Addressed PR comments

* Subscription ID Changed

* PR Comments 2

* Metadata Tests

* PR Comments Updated Docs
…rce code (Azure#20164)

* Add all files

* Add all code to module

* resolve changes

* Record securitySettings tests

* Record pricing tests

* Record securityAssessment and metadata

* Fix Alerts code and tests record and coverage

* Record and fix JitNetworkAccessPolicy tests

* Record assessments and metadata tests

* Record settings tests

* Add SubPlan support in pricing

* Change SecurityContact page type to list

* Fix and record SecurityContact tests

* Add support in evidence, techniques and sub techniques

* Pricings

* changes

* remove breaking changes

* Update ChangeLog.md

---------

Co-authored-by: Keren Damari <[email protected]>
Co-authored-by: Sulaiman Abu Rashed <[email protected]>
Co-authored-by: surashed <[email protected]>
* Fix ThreadJob installation error of smoke test

* Address review comments
* [DataFactory]Updated ADF .Net SDK version to 9.1.0

* update
* Nuget Update with Auto Rest

* CS files updates

* sln update
* Set up first CI try with Azure Pipelines

description here! [skip ci]

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* commit me

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* remove test yml

* rectify_git_url

---------

Co-authored-by: Hongtu Zhang (FA Talent) <[email protected]>
…tation to Azure Database Migration Service (classic) (Azure#20893)

* Rename Azure Database migration Service to Azure Database Migration Service (classic)

* fix PR comments
`-Confirm` in the examples were not in the correct format to override the confirmation prompt
…#20901)

* Fix the issue that CI doesn't check online version of help doc

* Fix the online version in help docs

* Fix the online version in help docs

* Fix the example issue

* Fix the example issue
* Added Snat parameter to firewall policy cmdlets

* Generated help for new cmdlet and updated for the existing ones

* fixed pipeline analyze issue

* Removed SupportsShouldProcess

* suppressed static analyzer

* Updated help per PR review comments

---------

Co-authored-by: Gizachew Eshetie <[email protected]>
* Fix/connectedk8s ps5 (Azure#20603)

* Create RSAHelper.ps1

* Update New-AzConnectedKubernetes.ps1

* Add try-catch and update function parameters

* Update New-AzConnectedKubernetes.ps1

* [Az.ConnectedKubernetes] Update ChangeLog  (Azure#20649)

* Update RSAHelper.ps1 (coding style)

* Update ChangeLog.md

* upgrade Az.ConnectedKubernetes from 0.7.0 to 0.7.1

---------

Co-authored-by: Ann Lu <[email protected]>
Skip PR creatation if there is not change in fabricbot.json
…zure#20917)

* spark pool isolate compute/nodesize related changes

* update change log

* updateazsynapselinkconnectionlandingzonecredential
* Add missing online version

* Add missing online version

* Add missing online version

* Fix the broken help files

* Supress the example exceptions

* Remove the supression the example exceptions
…tDoorWafPolicy (Azure#20908)

* {AzureFrontDoor} fixes Azure#20870 Adding Tag parameter to New-AzFrontDoorWafPolicy

fixes Azure#20870 

Adding Tag parameter to New-AzFrontDoorWafPolicy

This PR Allow the passing of tags when creating a new Azure Front Door Waf Policy resource. 
Currently, tags can be added in the portal but not via powershell for the FrontDoor WAF policy.

* Update ChangeLog.md

* Update src/FrontDoor/FrontDoor/ChangeLog.md

Co-authored-by: Beisi Zhou <[email protected]>

* Update src/FrontDoor/FrontDoor/Cmdlets/NewFrontDoorWafPolicy.cs

Co-authored-by: Beisi Zhou <[email protected]>

* Update NewFrontDoorWafPolicy.cs

* Updating the help docs New-AzFrontDoorWafPolicy.md

---------

Co-authored-by: Beisi Zhou <[email protected]>
* Move ServiceBus to main

* Update ChangeLog.md

---------

Co-authored-by: Beisi Zhou <[email protected]>
* add pipeline yml for syncing fabricbot.json aliases

* change git user name and email in script

* change inline script to GetWiki2Json.ps1 file

* remove unnecessary code

* change wrong dir

* change to my personal repo for test

* change the usage of token

* change CreatePR.ps1 for test

* correct ParseWiki2Json.ps1

* remove unnecessary output

* remove quote

* finish test, change back to Azure repo

* change branch name

* change some names

* remove the use of magic number

* change commit message

* remove redundant git pull

* change the way of getting wiki content

* change space to -

* add md

* set current dir

* use space

* use -

* still use ADOToken

* use a better wiki url

* test purpose

* test2

* test oauth

* test3

* finish test

* test again

* test

* finish  test

* test cron

* test double pr

* solve double pr

* test

* test

* test

* finish test

* test

* finish test

* test restapi

* te

* finish test

* test

* finish test

* filter pr

* test

* test

* test

* test

* finish test

* Solve pipeline error when no changes

* add newline at end of file

* change to pwsh

* test diff

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* testt

* testt

* testt

* testt

* Update sync-aliases.yml for Azure Pipelines

* testt

* testt

* test yml condition synthx

* add succeed

* add trim

* add null check

* add newline

* remove checkout

* use right url

* remove diff

---------

Co-authored-by: Hongtu Zhang (FA Talent) <[email protected]>
…-WhatIf parameter (Azure#20941)

* [AppService]: fix Azure#16816- New-AzWebAppSSLBinding is missing the -WhatIf parameter

* ReRecorded the failed tests

* Updated changelog.md
* add it to New-AzDiskConfig

* help doc and change log

* suppress false positive

---------

Co-authored-by: Theodore Chang <[email protected]>
grizzlytheodore and others added 9 commits February 17, 2023 10:45
* breaking change message

* changelog

---------

Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
…rk with DigiCert hubs (Azure#20938)

* IoT Hub SDK version update to 4.2.0 and fixed Get-AzIoTHub to work with DigiCert hubs

* Remove CertificateBodyDescription creation

* Reconfigure EventHubConsumerGroupName property

* update dps session records

* Fix DPS tests
* Move ServiceLinker to main

* Update Changelog.md

---------

Co-authored-by: Beisi Zhou <[email protected]>
* Move ManagedServiceIdentity to main

* Update Changelog.md

---------

Co-authored-by: Beisi Zhou <[email protected]>
…zure#20944)

* Fix Invoke-WebRequest in Win10 issue

* Add optional settings (+2 squashed commit)

Squashed commit:

[37a75ce5980] Add optional settings

[f90cd1a98ee] Add optional settings

* Install azure-arc helm release in azure-arc-release namespace (+1 squashed commits)

Squashed commits:

[49e9e01caf3] Install azure-arc helm release in azure-arc-release namespace (+1 squashed commits)

Squashed commits:

[9662ecff989] Install azure-arc helm release in azure-arc-release namespace

* Fix RSAHelper format

* Add Proxy settings (+1 squashed commits)

Squashed commits:

[28ff1d7f8cf] Add Proxy settings (+4 squashed commit)

Squashed commit:

[cdfe615ad63] Update warning messages

[5d46ec26806] Check credential

[db0351e75f5] Update parameter description

[79bf2b15c29] Modify parameter type

* Fix Invalid URI issue when passing diaplsy name of location (+1 squashed commits)

Squashed commits:

[c893de7a1b5] Fix Invalid URI issue when passing diaplsy name of location (+1 squashed commits)

Squashed commits:

[bc81f1915fb] Fix Invalid URI issue when passing diaplsy name of location

* Update examples

* Update ChangeLog

* Update parameter names and docs
* Test Sync docs between 2 repos under NoriZC

* Change to absolute temp location

* Split file while copying to doc repo

* Change branch name to checkout

* Change pr org

* Change file location

* Change file location 2

* Switch HEAD and Base

* Switch to MicrosoftDocs org and azure-bot.

* Add header to markdown file.

* Remove indents of header

* Set Create PR process as optional

* Try to skip pr when existed.

* Try to skip pr when existed

* Update pr description

* Update tools/SyncDocs.ps1

Co-authored-by: Yunchi Wang <[email protected]>

* Make the script name clear and add some comments.

* Update ps1 path

---------

Co-authored-by: Yunchi Wang <[email protected]>
* Register Microsoft.Monitor RP in Network cmdlet

Adding Microsoft.Monitor RP in Network PrivateLinkService cmdlet

Microsoft.Monitor RP supports
 - List Private Link Resource API
 - Get Private Endpoint Connection API
 - List Private Endpoint Connection API

It doesn't support Get Private Link Resource API yet

* Update Network change log

* Update src/Network/Network/ChangeLog.md

---------

Co-authored-by: Beisi Zhou <[email protected]>
@BethanyZhou BethanyZhou changed the base branch from main to Az.Storage-preview February 17, 2023 08:44
@BethanyZhou BethanyZhou added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Feb 17, 2023
@BethanyZhou
Copy link
Contributor Author

@wyunchi-ms , could you help check this rate limit issue?

@blueww
Copy link
Member

blueww commented Feb 20, 2023

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@blueww
Copy link
Member

blueww commented Feb 20, 2023

Close as #20973 is opened.

@blueww blueww closed this Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.