Skip to content

Conversation

@darrengiles
Copy link

added example of creating a test in a disabled state through powershell

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

added example of creating a test in a disabled state through powershell
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Mar 13, 2024

️✔️Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@AarDavMax
Copy link

This build appears to have failed, so I'm closing and reopening the PR to restart the build process.

@AarDavMax AarDavMax closed this Mar 13, 2024
@AarDavMax AarDavMax reopened this Mar 13, 2024
@AarDavMax
Copy link

#assign-reviewer:AaronMaxwell

@vidai-msft
Copy link
Contributor

@darrengiles This is an autorest module. The changes are supposed to happen in the generation branch instead of main. You need to update the files under the Examples folder on that branch. Thanks!

@github-actions
Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@AarDavMax
Copy link

@darrengiles I raised the following ICM. https://portal.microsofticm.com/imp/v3/incidents/incident/482477295/summary

The team responsible has requested changes before merging.

@vidai-msft
Copy link
Contributor

@darrengiles Please kindly note the cut off date of development for this sprint is by EOD next Monday. Let me know if you have any questions regarding this PR.

@darrengiles
Copy link
Author

@vidai-msft Hello, I don't quite understand what needs to be done for this PR. You mentioned the changes need to be made in another branch, correct? I'm don't think I know how to access this separate branch. Could you share more instructions please?

@AarDavMax
Copy link

@vidai-msft The desired changes are very clear within this PR. Please provide additional information related to your earlier comment. Neither @darrengiles or I have any idea what you're referring to when you said, "This is an autorest module. The changes are supposed to happen in the generation branch instead of main. You need to update the files under the Examples folder on that branch. Thanks!". What is the "generation branch" and where can we find the files under the Examples folder on that branch? Is there a work item we should fill out to have someone who works with "autorest modules" jump through the unique hoops for this content?

@vidai-msft
Copy link
Contributor

I have updated with PR [#24508]

@vidai-msft
Copy link
Contributor

Merged into main branch with #24510. Closing this PR.

@vidai-msft vidai-msft closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants