- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.1k
Migrate ApplicationInsights from generation to main #24510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | ️✔️Az.Accounts
 
 | 
| Type | Cmdlet | Description | Remediation | 
|---|---|---|---|
| Get-AzApplicationInsightsMyWorkbook | Get-AzApplicationInsightsMyWorkbook Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzApplicationInsightsMyWorkbook | Get-AzApplicationInsightsMyWorkbook changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzApplicationInsightsWorkbook | Get-AzApplicationInsightsWorkbook Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzApplicationInsightsWorkbook | Get-AzApplicationInsightsWorkbook changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzApplicationInsightsWorkbookRevision | Get-AzApplicationInsightsWorkbookRevision Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzApplicationInsightsWorkbookRevision | Get-AzApplicationInsightsWorkbookRevision changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzApplicationInsightsWorkbookTemplate | Get-AzApplicationInsightsWorkbookTemplate Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzApplicationInsightsWorkbookTemplate | Get-AzApplicationInsightsWorkbookTemplate changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzApplicationInsightsWorkbookTemplateGalleryObject | New-AzApplicationInsightsWorkbookTemplateGalleryObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | 
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Description | Remediation | 
|---|---|---|---|
| Get-AzApplicationInsightsMyWorkbook | Get-AzApplicationInsightsMyWorkbook Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzApplicationInsightsMyWorkbook | Get-AzApplicationInsightsMyWorkbook changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzApplicationInsightsWorkbook | Get-AzApplicationInsightsWorkbook Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzApplicationInsightsWorkbook | Get-AzApplicationInsightsWorkbook changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzApplicationInsightsWorkbookRevision | Get-AzApplicationInsightsWorkbookRevision Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzApplicationInsightsWorkbookRevision | Get-AzApplicationInsightsWorkbookRevision changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzApplicationInsightsWorkbookTemplate | Get-AzApplicationInsightsWorkbookTemplate Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzApplicationInsightsWorkbookTemplate | Get-AzApplicationInsightsWorkbookTemplate changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzApplicationInsightsWorkbookTemplateGalleryObject | New-AzApplicationInsightsWorkbookTemplateGalleryObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | 
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Get-AzApplicationInsightsWorkbookRevision 1 1 Is_Alias fl is an alias of 'Format-List'. fl Use formal name 'Format-List' of the alias 'fl'. ⚠️ New-AzApplicationInsightsContinuousExport 1 1 Unassigned_Variable New-AzStorageContainerSASToken -Context $context is a null-valued parameter value. -Context Assign value for $context. ⚠️ Set-AzApplicationInsightsContinuousExport 1 1 Unassigned_Variable New-AzStorageContainerSASToken -Context $context is a null-valued parameter value. -Context Assign value for $context. 
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Get-AzApplicationInsightsWorkbookRevision 1 1 Is_Alias fl is an alias of 'Format-List'. fl Use formal name 'Format-List' of the alias 'fl'. ⚠️ New-AzApplicationInsightsContinuousExport 1 1 Unassigned_Variable New-AzStorageContainerSASToken -Context $context is a null-valued parameter value. -Context Assign value for $context. ⚠️ Set-AzApplicationInsightsContinuousExport 1 1 Unassigned_Variable New-AzStorageContainerSASToken -Context $context is a null-valued parameter value. -Context Assign value for $context. 
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ApplicationInsights. Add a changelog record under Upcoming Release section with past tense. 
⚠️ Windows PowerShell - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ApplicationInsights. Add a changelog record under Upcoming Release section with past tense. 
⚠️ UX Metadata Check
⚠️ PowerShell Core - Windows
Type Module ResourceType SubResourceType Command Description ⚠️ Az.ApplicationInsights Microsoft.ApplicationInsights components Get-AzApplicationInsights The path /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.insights/components/{name} doesn't contains the right resource tpye: Microsoft.ApplicationInsights 
⚠️ Windows PowerShell - Windows
Type Module ResourceType SubResourceType Command Description ⚠️ Az.ApplicationInsights Microsoft.ApplicationInsights components Get-AzApplicationInsights The path /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.insights/components/{name} doesn't contains the right resource tpye: Microsoft.ApplicationInsights 
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.02 % Test coverage for the module cannot be lower than 50%. 
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.02% Test coverage for the module cannot be lower than 50%. 
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.02% Test coverage for the module cannot be lower than 50%. 
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.02% Test coverage for the module cannot be lower than 50%. 
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
2bec8c7    to
    2a0f582      
    Compare
  
    
              
                    vidai-msft
  
              
              approved these changes
              
                  
                    Mar 26, 2024 
                  
              
              
            
            
      
        
      
      
  
    6 tasks
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
     
Description
Migrate ApplicationInsights from generation to main
The last commit of src/ApplicationInsights in generation is:
commit 3d7de30 Author: Vincent Dai [email protected] Date: Mon Mar 25 19:22:39 2024 -0700 Update examples for New-AzApplicationInsightsWebTest (#24508)
Checklist