Update to USGovernmentActiveDirectoryEndpoint

[BernieEllis]

Description

Updated the USGovernmentActiveDirectoryEndpoint from login-us.microsoftonline.com to login.microsoftonline.us in AzureEnvironmentConstants.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

• [ Yes] I have read the contribution guidelines.
• [N/A ] If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
• [N/A] If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

• [Yes] Title of the pull request is clear and informative.
• [Yes] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
• [No breaking changes] The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

• [N/A] Pull request includes test coverage for the included changes.
• [N/A] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

• [N/A] New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
• [N/A] Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

• [N/A] Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
• [N/A] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
• [N/A] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

[cormacpayne]

@azuresdkci test this please

[cormacpayne]

@bernie-msft thanks for the PR, Bernarldo. This looks good to me, we just need to do some light validation on our side to ensure both endpoints work.

As a note to myself, the URL has changed, but the old one will continue to be supported moving forward, according to this article:

The Active Directory Authority for Azure Government has changed from https://login-us.microsoftonline.com to https://login.microsoftonline.us. The original URL will continue to work but all applications should be updated to the new authority URL.

[markcowl]

optimistic on-demand run here: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/151/

[BernieEllis]

Thanks Mark,

#sign-off

[BernieEllis]

Hi, I signed off on this. Was it ever merged?

[cormacpayne]

@bernie-msft I was able to log-in and run a few cmdlets in the AzureUSGovernment cloud with the new AD endpoint. This should be good to merge.

[cormacpayne]

@bernie-msft before we merge this, our team is discussing how we want to do versioning around this change (since it touches common code used by all of the modules we ship). Once we figure that out, we will merge this.

[BernieEllis]

Thanks Cormac, I fear that some service teams may be using the USGov endpoints returned by Get-AzureRMEnvironment to influence what endpoints to use as they deploy instances within the AzureGov boundary. Do you anticipate when the approach will be decided? Thanks, Bernarldo From: Cormac McCarthy [mailto:[email protected]] Sent: Tuesday, November 21, 2017 12:49 PM To: Azure/azure-powershell <[email protected]> Cc: Bernarldo Ellis <[email protected]>; Mention <[email protected]> Subject: Re: [Azure/azure-powershell] Update to USGovernmentActiveDirectoryEndpoint (#4822) @bernie-msft<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbernie-msft&data=02%7C01%7Cbeellis%40exchange.microsoft.com%7C1010c5883f1241817d6108d531081b3c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636468833245137499&sdata=29K7jdXlvLQ6FGo6XUjBWm8mVAyuyYrKJetqib9jlF8%3D&reserved=0> before we merge this, our team is discussing how we want to do versioning around this change (since it touches common code used by all of the modules we ship). Once we figure that out, we will merge this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-powershell%2Fpull%2F4822%23issuecomment-346105342&data=02%7C01%7Cbeellis%40exchange.microsoft.com%7C1010c5883f1241817d6108d531081b3c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636468833245137499&sdata=%2BU1sSdYnweuvLyIm59RwUiN0P6NdHuW3LQtHA%2B2jy1Q%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAePAip7M6iQX0Pwdk2iRwfJfwaQklVG6ks5s4wz6gaJpZM4QA7NU&data=02%7C01%7Cbeellis%40exchange.microsoft.com%7C1010c5883f1241817d6108d531081b3c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636468833245137499&sdata=UI7UoG8edvsk1m2%2BQgpx5aWq%2BZjEGVWJUL45MIzEKxs%3D&reserved=0>.

[cormacpayne]

On-demand: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/209/

[BernieEllis]

Thanks, do you know when this version will ship publicly? From: Cormac McCarthy [mailto:[email protected]] Sent: Thursday, November 30, 2017 11:09 AM To: Azure/azure-powershell <[email protected]> Cc: Bernarldo Ellis <[email protected]>; Mention <[email protected]> Subject: Re: [Azure/azure-powershell] Update to USGovernmentActiveDirectoryEndpoint (#4822) Merged #4822<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-powershell%2Fpull%2F4822&data=02%7C01%7Cbeellis%40exchange.microsoft.com%7Cf5d1c9e76edb4af67e6b08d5380cb194%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636476549594158676&sdata=eAc%2B2h8rDMu0drUqnA6IlTI3%2B6UctnhRJeofD18G4qM%3D&reserved=0>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-powershell%2Fpull%2F4822%23event-1365955772&data=02%7C01%7Cbeellis%40exchange.microsoft.com%7Cf5d1c9e76edb4af67e6b08d5380cb194%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636476549594158676&sdata=tChoFAL10MsyLyo2PKZ%2FDzVR4WbQ%2BxB0LVbDO2wsLYA%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAePAio-vN5fIL5MuiVHekZQD2ZcbhvLEks5s7tMmgaJpZM4QA7NU&data=02%7C01%7Cbeellis%40exchange.microsoft.com%7Cf5d1c9e76edb4af67e6b08d5380cb194%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636476549594158676&sdata=8wpLxw6%2FTHzsgHJ4xNxeMOr5ALPwrhPMk7dds207zRQ%3D&reserved=0>.

[cormacpayne]

@bernie-msft our upcoming release is next Friday (12/8), so it will be available then

[BernieEllis]

Great, thank you! From: Cormac McCarthy [mailto:[email protected]] Sent: Thursday, November 30, 2017 11:25 AM To: Azure/azure-powershell <[email protected]> Cc: Bernarldo Ellis <[email protected]>; Mention <[email protected]> Subject: Re: [Azure/azure-powershell] Update to USGovernmentActiveDirectoryEndpoint (#4822) @bernie-msft<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbernie-msft&data=02%7C01%7Cbeellis%40exchange.microsoft.com%7Cb824139d35ce435f4a0508d5380ef036%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636476559169548966&sdata=WgLIodlPbmmm%2BZJm2RA%2BBmg11F%2Bg83Cw%2BCnhp%2FdWnx0%3D&reserved=0> our upcoming release is next Friday (12/8), so it will be available then — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-powershell%2Fpull%2F4822%23issuecomment-348239606&data=02%7C01%7Cbeellis%40exchange.microsoft.com%7Cb824139d35ce435f4a0508d5380ef036%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636476559169548966&sdata=6OFXHZ0vz803YYDvwcktN3tAB7%2BSHwRmQ%2BhefJZM9sI%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAePAitprHj8dMje5vhwlzDgAEsFjOymfks5s7taSgaJpZM4QA7NU&data=02%7C01%7Cbeellis%40exchange.microsoft.com%7Cb824139d35ce435f4a0508d5380ef036%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636476559169548966&sdata=QzJEGFABh2KF1TFEmdKnfT8DMvE5xC3bpPI4ayzPxOw%3D&reserved=0>.