Skip to content

updated_rn_video_version_migrated_viewproptypes_to_deprecated-react-n… #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2023
Merged

updated_rn_video_version_migrated_viewproptypes_to_deprecated-react-n… #120

merged 1 commit into from
May 24, 2023

Conversation

@dan-arvi
Copy link
Collaborator

@dan-arvi dan-arvi commented May 23, 2023

updated_rn_video_version_migrated_viewproptypes_to_deprecated-react-native-prop-types

Related Issue

#118
#119

Description

  1. ViewPropTypes migrated to deprecated-react-native-prop-types.
  2. Made the changes for ViewPropTypes in the required places in the code.
  3. Updated react-native-video package version, from 5.2.0 to 5.2.1.
  4. Updating the react-native-video package version fixes the ViewPropTypes issue and patch file issue.

@dan-arvi dan-arvi requested a review from pragadeeshk May 23, 2023 13:11
@dan-arvi dan-arvi marked this pull request as ready for review May 24, 2023 06:55
@dan-arvi dan-arvi changed the base branch from fork-main to reactnative/release-2.2.34 May 24, 2023 07:16
pragadeeshk
pragadeeshk approved these changes May 24, 2023
View reviewed changes
Copy link

@pragadeeshk pragadeeshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pragadeeshk pragadeeshk merged commit f5586e4 into reactnative/release-2.2.34 May 24, 2023
@pragadeeshk pragadeeshk deleted the updated_viewproptypes_and_RN_video branch May 24, 2023 07:19
@pragadeeshk pragadeeshk mentioned this pull request May 24, 2023
Closed
dan-arvi added a commit that referenced this pull request May 24, 2023
@pragadeeshk @dan-arvi
Reactnative/release 2.2.34 (#121)
7cfd7a3 
* handled none associatedInputs case (#117)

* version bump

* updated_rn_video_version_migrated_viewproptypes_to_deprecated-react-native-prop-types (#120)

* Version bump

---------

Co-authored-by: dan-arvi <[email protected]>
@cameroncharles cameroncharles mentioned this pull request May 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pragadeeshk pragadeeshk pragadeeshk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dan-arvi @pragadeeshk