Fix up deprecated Text.propType usage #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Not an issue but related to PRs
#120
#119
Description
This was missed in the other PRs around now deprecated prop type declarations, Text.propTypes was also removed from the core react-native library but for some reason doesn't throw an exception if used like View.proptypes and the others, itll just cause the app to crash when it tries to access the prop.
Solution is the same as the other PRs here and utelises the deprecated-react-native-prop-types library
How Verified
I have a local fork with all three PRs in place, without this change my app crashes as soon as it tries to render an adaptive card because it tries to access the now removes prop, with this PR it does not and everything works again.