Pack all experiments individually #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and search for sln files explicitly
rather than the sln
michael-hawker
force-pushed
the
PackAllExperiments
branch
from
53b1e46 to
dfbbfa1
Compare
|
rebased on main, so we should see clean build |
and search for sln files explicitly
rather than the sln
michael-hawker
force-pushed
the
PackAllExperiments
branch
from
dfbbfa1 to
7ec7e81
Compare
|
@mrlacey looks like the relative path is misconfigured. |
| working-directory: ./labs/CanvasLayout/src | ||
| run: msbuild -t:pack /p:Configuration=Release /p:DebugType=Portable | ||
| # Build All Packages | ||
| - name: pack experiments |
There was a problem hiding this comment.
Question for later: Do we want to even try packing the experiments unless this is a merge to main? i.e. add the if: ${{github.ref == 'refs/heads/main'}} condition we do on the push below? Considering we're building them above, do we foresee running into different issues on the pack command? Don't know how long this step will take overall as we get more experiments.
michael-hawker
approved these changes
May 13, 2022
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
* Pack all experiments * pack experiments in WinUI3 build too * fix rogue newline char * simplify script and search for sln files explicitly * pack individual projects rather than the sln * move to common scripts folder * Pack all experiments * pack experiments in WinUI3 build too * fix rogue newline char * simplify script and search for sln files explicitly * pack individual projects rather than the sln * move to common scripts folder * fix relative path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2
This packs all experiments separately without having to list them explicitly
Implemented as a PowerShell script as actions can't easily do loops through directories.
Alternatives involve adding an external workflow (either as a dependency or to do "clever" (hard to understand/debug/maintain) nested workflows with a matrix.)