Skip to content

Pack all experiments individually #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 13, 2022
Merged

Pack all experiments individually #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
90bb1a3
Pack all experiments
mrlacey May 10, 2022
0cb16fc
pack experiments in WinUI3 build too
mrlacey May 10, 2022
ee08ad2
fix rogue newline char
mrlacey May 10, 2022
201500f
simplify script
mrlacey May 11, 2022
1490bf4
pack individual projects
mrlacey May 11, 2022
53b1e46
move to common scripts folder
mrlacey May 11, 2022
efaf131
Pack all experiments
mrlacey May 10, 2022
a809be0
pack experiments in WinUI3 build too
mrlacey May 10, 2022
b65265e
fix rogue newline char
mrlacey May 10, 2022
314370d
simplify script
mrlacey May 11, 2022
2254a80
pack individual projects
mrlacey May 11, 2022
7ec7e81
move to common scripts folder
mrlacey May 11, 2022
df22703
Merge branch 'PackAllExperiments' of https://github.com/CommunityTool…
mrlacey May 13, 2022
711408a
fix relative path
mrlacey May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ jobs:
# working-directory: ./
run: msbuild.exe Toolkit.Labs.All.sln /restore -p:Configuration=Release

# Build All Packages - TODO: Detect experiments
- name: pack CanvasLayout
working-directory: ./labs/CanvasLayout/src
run: msbuild -t:pack /p:Configuration=Release /p:DebugType=Portable
# Build All Packages
- name: pack experiments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for later: Do we want to even try packing the experiments unless this is a merge to main? i.e. add the if: ${{github.ref == 'refs/heads/main'}} condition we do on the push below? Considering we're building them above, do we foresee running into different issues on the pack command? Don't know how long this step will take overall as we get more experiments.

working-directory: ./common/Scripts/
run: ./PackEachExperiment.ps1 all

# Push Packages to our DevOps Artifacts Feed
- name: Add source
Expand Down Expand Up @@ -129,10 +129,10 @@ jobs:
# working-directory: ./
run: msbuild.exe Toolkit.Labs.All.sln /restore -p:Configuration=Release

# Build All Packages - TODO: Detect experiments
- name: pack CanvasLayout
working-directory: ./labs/CanvasLayout/src
run: msbuild -t:pack /p:Configuration=Release /p:DebugType=Portable
# Build All Packages
- name: pack experiments
working-directory: ./common/Scripts/
run: ./PackEachExperiment.ps1 all

# Push Packages to our DevOps Artifacts Feed
- name: Add source
Expand Down
4 changes: 4 additions & 0 deletions common/Scripts/PackEachExperiment.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

foreach ($experimentProjPath in Get-ChildItem -Recurse -Path '../../labs/*/src/*.csproj') {
& msbuild.exe -t:pack /p:Configuration=Release /p:DebugType=Portable $experimentProjPath
}