-
Notifications
You must be signed in to change notification settings - Fork 314
Refactor instrumentation modules for jetty, netty and tibco #9547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: a08cd6e | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~a08cd6e0ca, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065688
Total [baseline] (10.831 s) : 0, 10831201
Agent [candidate] (1.065 s) : 0, 1065219
Total [candidate] (10.775 s) : 0, 10775437
section appsec
Agent [baseline] (1.241 s) : 0, 1240563
Total [baseline] (10.997 s) : 0, 10997055
Agent [candidate] (1.233 s) : 0, 1233416
Total [candidate] (11.059 s) : 0, 11058847
section iast
Agent [baseline] (1.191 s) : 0, 1191040
Total [baseline] (11.075 s) : 0, 11074617
Agent [candidate] (1.193 s) : 0, 1192936
Total [candidate] (11.072 s) : 0, 11071859
section profiling
Agent [baseline] (1.215 s) : 0, 1214611
Total [baseline] (10.857 s) : 0, 10857214
Agent [candidate] (1.208 s) : 0, 1208168
Total [candidate] (10.916 s) : 0, 10916229
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~a08cd6e0ca, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (734.919 ms) : 0, 734919
BytebuddyAgent [candidate] (736.462 ms) : 0, 736462
GlobalTracer [baseline] (254.12 ms) : 0, 254120
GlobalTracer [candidate] (252.404 ms) : 0, 252404
AppSec [baseline] (30.647 ms) : 0, 30647
AppSec [candidate] (30.333 ms) : 0, 30333
Debugger [baseline] (6.434 ms) : 0, 6434
Debugger [candidate] (6.453 ms) : 0, 6453
Remote Config [baseline] (686.026 µs) : 0, 686
Remote Config [candidate] (689.844 µs) : 0, 690
Telemetry [baseline] (16.333 ms) : 0, 16333
Telemetry [candidate] (16.265 ms) : 0, 16265
section appsec
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (759.931 ms) : 0, 759931
BytebuddyAgent [candidate] (755.043 ms) : 0, 755043
GlobalTracer [baseline] (246.599 ms) : 0, 246599
GlobalTracer [candidate] (245.339 ms) : 0, 245339
AppSec [baseline] (172.292 ms) : 0, 172292
AppSec [candidate] (171.518 ms) : 0, 171518
Debugger [baseline] (6.043 ms) : 0, 6043
Debugger [candidate] (5.969 ms) : 0, 5969
Remote Config [baseline] (641.838 µs) : 0, 642
Remote Config [candidate] (621.714 µs) : 0, 622
Telemetry [baseline] (8.537 ms) : 0, 8537
Telemetry [candidate] (8.49 ms) : 0, 8490
IAST [baseline] (23.855 ms) : 0, 23855
IAST [candidate] (23.791 ms) : 0, 23791
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (852.629 ms) : 0, 852629
BytebuddyAgent [candidate] (854.574 ms) : 0, 854574
GlobalTracer [baseline] (245.866 ms) : 0, 245866
GlobalTracer [candidate] (245.383 ms) : 0, 245383
AppSec [baseline] (26.32 ms) : 0, 26320
AppSec [candidate] (26.139 ms) : 0, 26139
Debugger [baseline] (6.114 ms) : 0, 6114
Debugger [candidate] (6.037 ms) : 0, 6037
Remote Config [baseline] (594.89 µs) : 0, 595
Remote Config [candidate] (592.457 µs) : 0, 592
Telemetry [baseline] (8.265 ms) : 0, 8265
Telemetry [candidate] (8.133 ms) : 0, 8133
IAST [baseline] (28.845 ms) : 0, 28845
IAST [candidate] (29.54 ms) : 0, 29540
section profiling
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (765.85 ms) : 0, 765850
BytebuddyAgent [candidate] (761.184 ms) : 0, 761184
GlobalTracer [baseline] (234.064 ms) : 0, 234064
GlobalTracer [candidate] (233.393 ms) : 0, 233393
AppSec [baseline] (30.628 ms) : 0, 30628
AppSec [candidate] (31.026 ms) : 0, 31026
Debugger [baseline] (13.728 ms) : 0, 13728
Debugger [candidate] (11.219 ms) : 0, 11219
Remote Config [baseline] (758.91 µs) : 0, 759
Remote Config [candidate] (1.494 ms) : 0, 1494
Telemetry [baseline] (9.365 ms) : 0, 9365
Telemetry [candidate] (10.176 ms) : 0, 10176
ProfilingAgent [baseline] (107.395 ms) : 0, 107395
ProfilingAgent [candidate] (107.173 ms) : 0, 107173
Profiling [baseline] (108.041 ms) : 0, 108041
Profiling [candidate] (107.841 ms) : 0, 107841
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~a08cd6e0ca, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059837
Total [baseline] (8.633 s) : 0, 8632510
Agent [candidate] (1.062 s) : 0, 1061920
Total [candidate] (8.63 s) : 0, 8629541
section iast
Agent [baseline] (1.198 s) : 0, 1197561
Total [baseline] (9.28 s) : 0, 9279982
Agent [candidate] (1.194 s) : 0, 1194134
Total [candidate] (9.326 s) : 0, 9326287
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~a08cd6e0ca, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (731.772 ms) : 0, 731772
BytebuddyAgent [candidate] (732.921 ms) : 0, 732921
GlobalTracer [baseline] (251.799 ms) : 0, 251799
GlobalTracer [candidate] (252.514 ms) : 0, 252514
AppSec [baseline] (30.505 ms) : 0, 30505
AppSec [candidate] (30.612 ms) : 0, 30612
Debugger [baseline] (6.395 ms) : 0, 6395
Debugger [candidate] (6.389 ms) : 0, 6389
Remote Config [baseline] (694.899 µs) : 0, 695
Remote Config [candidate] (701.196 µs) : 0, 701
Telemetry [baseline] (16.247 ms) : 0, 16247
Telemetry [candidate] (16.35 ms) : 0, 16350
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (858.372 ms) : 0, 858372
BytebuddyAgent [candidate] (855.418 ms) : 0, 855418
GlobalTracer [baseline] (244.769 ms) : 0, 244769
GlobalTracer [candidate] (245.712 ms) : 0, 245712
AppSec [baseline] (26.522 ms) : 0, 26522
AppSec [candidate] (26.984 ms) : 0, 26984
Debugger [baseline] (6.081 ms) : 0, 6081
Debugger [candidate] (6.02 ms) : 0, 6020
Remote Config [baseline] (621.629 µs) : 0, 622
Remote Config [candidate] (627.672 µs) : 0, 628
Telemetry [baseline] (8.169 ms) : 0, 8169
Telemetry [candidate] (8.213 ms) : 0, 8213
IAST [baseline] (30.527 ms) : 0, 30527
IAST [candidate] (28.763 ms) : 0, 28763
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~a08cd6e0ca, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section baseline
no_agent (37.87 ms) : 37565, 38175
. : milestone, 37870,
appsec (46.529 ms) : 46133, 46925
. : milestone, 46529,
code_origins (46.072 ms) : 45687, 46456
. : milestone, 46072,
iast (46.413 ms) : 46005, 46820
. : milestone, 46413,
profiling (49.99 ms) : 49537, 50442
. : milestone, 49990,
tracing (44.139 ms) : 43773, 44505
. : milestone, 44139,
section candidate
no_agent (36.057 ms) : 35769, 36345
. : milestone, 36057,
appsec (47.46 ms) : 47053, 47867
. : milestone, 47460,
code_origins (43.539 ms) : 43173, 43904
. : milestone, 43539,
iast (44.895 ms) : 44505, 45285
. : milestone, 44895,
profiling (48.551 ms) : 48073, 49028
. : milestone, 48551,
tracing (43.944 ms) : 43569, 44320
. : milestone, 43944,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~a08cd6e0ca, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section baseline
no_agent (4.355 ms) : 4301, 4409
. : milestone, 4355,
iast (9.699 ms) : 9535, 9862
. : milestone, 9699,
iast_FULL (14.533 ms) : 14238, 14828
. : milestone, 14533,
iast_GLOBAL (10.572 ms) : 10385, 10759
. : milestone, 10572,
profiling (9.459 ms) : 9303, 9614
. : milestone, 9459,
tracing (7.638 ms) : 7531, 7745
. : milestone, 7638,
section candidate
no_agent (4.37 ms) : 4321, 4419
. : milestone, 4370,
iast (9.6 ms) : 9438, 9762
. : milestone, 9600,
iast_FULL (14.657 ms) : 14368, 14946
. : milestone, 14657,
iast_GLOBAL (10.401 ms) : 10213, 10588
. : milestone, 10401,
profiling (9.152 ms) : 9002, 9301
. : milestone, 9152,
tracing (7.607 ms) : 7492, 7722
. : milestone, 7607,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~a08cd6e0ca, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section baseline
no_agent (15.564 s) : 15564000, 15564000
. : milestone, 15564000,
appsec (14.834 s) : 14834000, 14834000
. : milestone, 14834000,
iast (18.585 s) : 18585000, 18585000
. : milestone, 18585000,
iast_GLOBAL (18.167 s) : 18167000, 18167000
. : milestone, 18167000,
profiling (16.094 s) : 16094000, 16094000
. : milestone, 16094000,
tracing (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
section candidate
no_agent (15.064 s) : 15064000, 15064000
. : milestone, 15064000,
appsec (14.8 s) : 14800000, 14800000
. : milestone, 14800000,
iast (18.593 s) : 18593000, 18593000
. : milestone, 18593000,
iast_GLOBAL (18.162 s) : 18162000, 18162000
. : milestone, 18162000,
profiling (15.584 s) : 15584000, 15584000
. : milestone, 15584000,
tracing (14.932 s) : 14932000, 14932000
. : milestone, 14932000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~a08cd6e0ca, baseline=1.54.0-SNAPSHOT~9fc16bb0e5
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.721 ms) : 3503, 3939
. : milestone, 3721,
iast (2.203 ms) : 2139, 2266
. : milestone, 2203,
iast_GLOBAL (2.246 ms) : 2182, 2309
. : milestone, 2246,
profiling (2.041 ms) : 1990, 2091
. : milestone, 2041,
tracing (2.027 ms) : 1978, 2076
. : milestone, 2027,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.712 ms) : 3495, 3928
. : milestone, 3712,
iast (2.194 ms) : 2131, 2256
. : milestone, 2194,
iast_GLOBAL (2.23 ms) : 2167, 2292
. : milestone, 2230,
profiling (2.043 ms) : 1993, 2094
. : milestone, 2043,
tracing (2.019 ms) : 1970, 2068
. : milestone, 2019,
|
What Does This Do
Refactor instrumentation modules for jetty, netty and tibco according to naming conventions
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]