-
Notifications
You must be signed in to change notification settings - Fork 314
Fix instrumentation refactoring #9826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 740ec96 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~740ec96483, baseline=1.55.0-SNAPSHOT~30451d7c0a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021065
Total [baseline] (10.711 s) : 0, 10710767
Agent [candidate] (1.02 s) : 0, 1020235
Total [candidate] (10.795 s) : 0, 10795365
section appsec
Agent [baseline] (1.203 s) : 0, 1202505
Total [baseline] (10.784 s) : 0, 10784075
Agent [candidate] (1.201 s) : 0, 1201353
Total [candidate] (10.796 s) : 0, 10795941
section iast
Agent [baseline] (1.15 s) : 0, 1150051
Total [baseline] (11.007 s) : 0, 11007002
Agent [candidate] (1.155 s) : 0, 1154677
Total [candidate] (11.106 s) : 0, 11105949
section profiling
Agent [baseline] (1.164 s) : 0, 1164003
Total [baseline] (10.812 s) : 0, 10811551
Agent [candidate] (1.162 s) : 0, 1161672
Total [candidate] (10.921 s) : 0, 10920680
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~740ec96483, baseline=1.55.0-SNAPSHOT~30451d7c0a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (695.939 ms) : 0, 695939
BytebuddyAgent [candidate] (695.018 ms) : 0, 695018
GlobalTracer [baseline] (244.282 ms) : 0, 244282
GlobalTracer [candidate] (243.469 ms) : 0, 243469
AppSec [baseline] (32.251 ms) : 0, 32251
AppSec [candidate] (32.344 ms) : 0, 32344
Debugger [baseline] (6.292 ms) : 0, 6292
Debugger [candidate] (6.325 ms) : 0, 6325
Remote Config [baseline] (683.21 µs) : 0, 683
Remote Config [candidate] (678.408 µs) : 0, 678
Telemetry [baseline] (9.368 ms) : 0, 9368
Telemetry [candidate] (9.323 ms) : 0, 9323
Flare Poller [baseline] (9.466 ms) : 0, 9466
Flare Poller [candidate] (10.334 ms) : 0, 10334
section appsec
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (723.477 ms) : 0, 723477
BytebuddyAgent [candidate] (722.21 ms) : 0, 722210
GlobalTracer [baseline] (236.32 ms) : 0, 236320
GlobalTracer [candidate] (236.363 ms) : 0, 236363
AppSec [baseline] (175.628 ms) : 0, 175628
AppSec [candidate] (175.82 ms) : 0, 175820
Debugger [baseline] (6.099 ms) : 0, 6099
Debugger [candidate] (6.109 ms) : 0, 6109
Remote Config [baseline] (635.668 µs) : 0, 636
Remote Config [candidate] (645.192 µs) : 0, 645
Telemetry [baseline] (8.568 ms) : 0, 8568
Telemetry [candidate] (8.575 ms) : 0, 8575
Flare Poller [baseline] (3.907 ms) : 0, 3907
Flare Poller [candidate] (3.902 ms) : 0, 3902
IAST [baseline] (25.053 ms) : 0, 25053
IAST [candidate] (25.009 ms) : 0, 25009
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (813.96 ms) : 0, 813960
BytebuddyAgent [candidate] (817.675 ms) : 0, 817675
GlobalTracer [baseline] (231.262 ms) : 0, 231262
GlobalTracer [candidate] (232.444 ms) : 0, 232444
AppSec [baseline] (35.496 ms) : 0, 35496
AppSec [candidate] (35.1 ms) : 0, 35100
Debugger [baseline] (6.154 ms) : 0, 6154
Debugger [candidate] (6.156 ms) : 0, 6156
Remote Config [baseline] (599.219 µs) : 0, 599
Remote Config [candidate] (602.511 µs) : 0, 603
Telemetry [baseline] (8.653 ms) : 0, 8653
Telemetry [candidate] (8.818 ms) : 0, 8818
Flare Poller [baseline] (4.288 ms) : 0, 4288
Flare Poller [candidate] (4.276 ms) : 0, 4276
IAST [baseline] (26.639 ms) : 0, 26639
IAST [candidate] (26.685 ms) : 0, 26685
section profiling
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (720.289 ms) : 0, 720289
BytebuddyAgent [candidate] (718.979 ms) : 0, 718979
GlobalTracer [baseline] (219.063 ms) : 0, 219063
GlobalTracer [candidate] (218.758 ms) : 0, 218758
AppSec [baseline] (32.399 ms) : 0, 32399
AppSec [candidate] (32.335 ms) : 0, 32335
Debugger [baseline] (7.406 ms) : 0, 7406
Debugger [candidate] (6.717 ms) : 0, 6717
Remote Config [baseline] (692.273 µs) : 0, 692
Remote Config [candidate] (683.046 µs) : 0, 683
Telemetry [baseline] (14.236 ms) : 0, 14236
Telemetry [candidate] (15.621 ms) : 0, 15621
Flare Poller [baseline] (4.934 ms) : 0, 4934
Flare Poller [candidate] (4.089 ms) : 0, 4089
ProfilingAgent [baseline] (109.559 ms) : 0, 109559
ProfilingAgent [candidate] (109.285 ms) : 0, 109285
Profiling [baseline] (110.211 ms) : 0, 110211
Profiling [candidate] (109.922 ms) : 0, 109922
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~740ec96483, baseline=1.55.0-SNAPSHOT~30451d7c0a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022318
Total [baseline] (8.728 s) : 0, 8728199
Agent [candidate] (1.023 s) : 0, 1023434
Total [candidate] (8.657 s) : 0, 8656598
section iast
Agent [baseline] (1.15 s) : 0, 1150447
Total [baseline] (9.28 s) : 0, 9279663
Agent [candidate] (1.156 s) : 0, 1156202
Total [candidate] (9.3 s) : 0, 9299519
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~740ec96483, baseline=1.55.0-SNAPSHOT~30451d7c0a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (695.663 ms) : 0, 695663
BytebuddyAgent [candidate] (696.947 ms) : 0, 696947
GlobalTracer [baseline] (243.984 ms) : 0, 243984
GlobalTracer [candidate] (243.868 ms) : 0, 243868
AppSec [baseline] (32.542 ms) : 0, 32542
AppSec [candidate] (32.219 ms) : 0, 32219
Debugger [baseline] (6.391 ms) : 0, 6391
Debugger [candidate] (6.309 ms) : 0, 6309
Remote Config [baseline] (688.116 µs) : 0, 688
Remote Config [candidate] (680.858 µs) : 0, 681
Telemetry [baseline] (9.371 ms) : 0, 9371
Telemetry [candidate] (9.273 ms) : 0, 9273
Flare Poller [baseline] (10.994 ms) : 0, 10994
Flare Poller [candidate] (11.607 ms) : 0, 11607
section iast
crashtracking [baseline] (1.489 ms) : 0, 1489
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (814.546 ms) : 0, 814546
BytebuddyAgent [candidate] (818.552 ms) : 0, 818552
GlobalTracer [baseline] (231.498 ms) : 0, 231498
GlobalTracer [candidate] (232.847 ms) : 0, 232847
AppSec [baseline] (35.035 ms) : 0, 35035
AppSec [candidate] (35.397 ms) : 0, 35397
Debugger [baseline] (6.137 ms) : 0, 6137
Debugger [candidate] (6.134 ms) : 0, 6134
Remote Config [baseline] (615.54 µs) : 0, 616
Remote Config [candidate] (603.098 µs) : 0, 603
Telemetry [baseline] (8.689 ms) : 0, 8689
Telemetry [candidate] (8.59 ms) : 0, 8590
Flare Poller [baseline] (4.289 ms) : 0, 4289
Flare Poller [candidate] (4.33 ms) : 0, 4330
IAST [baseline] (26.662 ms) : 0, 26662
IAST [candidate] (26.791 ms) : 0, 26791
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~740ec96483, baseline=1.55.0-SNAPSHOT~30451d7c0a
dateFormat X
axisFormat %s
section baseline
no_agent (4.424 ms) : 4374, 4473
. : milestone, 4424,
iast (10.022 ms) : 9851, 10193
. : milestone, 10022,
iast_FULL (15.393 ms) : 15084, 15703
. : milestone, 15393,
iast_GLOBAL (10.987 ms) : 10792, 11182
. : milestone, 10987,
profiling (8.569 ms) : 8432, 8707
. : milestone, 8569,
tracing (7.664 ms) : 7545, 7783
. : milestone, 7664,
section candidate
no_agent (4.361 ms) : 4305, 4417
. : milestone, 4361,
iast (9.784 ms) : 9621, 9948
. : milestone, 9784,
iast_FULL (14.695 ms) : 14404, 14986
. : milestone, 14695,
iast_GLOBAL (11.022 ms) : 10823, 11222
. : milestone, 11022,
profiling (8.891 ms) : 8749, 9034
. : milestone, 8891,
tracing (7.792 ms) : 7675, 7908
. : milestone, 7792,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~740ec96483, baseline=1.55.0-SNAPSHOT~30451d7c0a
dateFormat X
axisFormat %s
section baseline
no_agent (38.101 ms) : 37778, 38424
. : milestone, 38101,
appsec (49.473 ms) : 49014, 49932
. : milestone, 49473,
code_origins (42.749 ms) : 42382, 43117
. : milestone, 42749,
iast (45.158 ms) : 44762, 45553
. : milestone, 45158,
profiling (51.067 ms) : 50615, 51519
. : milestone, 51067,
tracing (43.239 ms) : 42879, 43599
. : milestone, 43239,
section candidate
no_agent (38.491 ms) : 38181, 38801
. : milestone, 38491,
appsec (49.189 ms) : 48749, 49630
. : milestone, 49189,
code_origins (42.427 ms) : 42075, 42779
. : milestone, 42427,
iast (43.838 ms) : 43461, 44214
. : milestone, 43838,
profiling (47.983 ms) : 47533, 48434
. : milestone, 47983,
tracing (44.007 ms) : 43623, 44391
. : milestone, 44007,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~740ec96483, baseline=1.55.0-SNAPSHOT~30451d7c0a
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.734 ms) : 3516, 3952
. : milestone, 3734,
iast (2.209 ms) : 2145, 2272
. : milestone, 2209,
iast_GLOBAL (2.241 ms) : 2177, 2305
. : milestone, 2241,
profiling (2.072 ms) : 2020, 2124
. : milestone, 2072,
tracing (2.033 ms) : 1983, 2083
. : milestone, 2033,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.457 ms) : 2407, 2508
. : milestone, 2457,
iast (2.204 ms) : 2140, 2267
. : milestone, 2204,
iast_GLOBAL (2.253 ms) : 2189, 2316
. : milestone, 2253,
profiling (2.053 ms) : 2002, 2104
. : milestone, 2053,
tracing (2.032 ms) : 1982, 2082
. : milestone, 2032,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~740ec96483, baseline=1.55.0-SNAPSHOT~30451d7c0a
dateFormat X
axisFormat %s
section baseline
no_agent (14.794 s) : 14794000, 14794000
. : milestone, 14794000,
appsec (14.979 s) : 14979000, 14979000
. : milestone, 14979000,
iast (18.559 s) : 18559000, 18559000
. : milestone, 18559000,
iast_GLOBAL (17.76 s) : 17760000, 17760000
. : milestone, 17760000,
profiling (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
tracing (15.131 s) : 15131000, 15131000
. : milestone, 15131000,
section candidate
no_agent (15.189 s) : 15189000, 15189000
. : milestone, 15189000,
appsec (14.776 s) : 14776000, 14776000
. : milestone, 14776000,
iast (18.671 s) : 18671000, 18671000
. : milestone, 18671000,
iast_GLOBAL (17.999 s) : 17999000, 17999000
. : milestone, 17999000,
profiling (15.282 s) : 15282000, 15282000
. : milestone, 15282000,
tracing (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
|
What Does This Do
Fix #9547 by reintroducing jetty benchmark project
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]