Moving config gen task dependency from Gradle build file to SupportedConfigPlugin
#9714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhlidd
added
tag: no release notes
|
🎯 Code Coverage 🔗 Commit SHA: 677efff | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~677efff2a1, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1015542
Total [baseline] (10.719 s) : 0, 10719371
Agent [candidate] (1.022 s) : 0, 1021798
Total [candidate] (10.725 s) : 0, 10724611
section appsec
Agent [baseline] (1.2 s) : 0, 1200222
Total [baseline] (11.124 s) : 0, 11124161
Agent [candidate] (1.193 s) : 0, 1193375
Total [candidate] (10.98 s) : 0, 10979596
section iast
Agent [baseline] (1.149 s) : 0, 1148669
Total [baseline] (11.054 s) : 0, 11053539
Agent [candidate] (1.151 s) : 0, 1151271
Total [candidate] (10.971 s) : 0, 10971238
section profiling
Agent [baseline] (1.159 s) : 0, 1159285
Total [baseline] (11.025 s) : 0, 11024510
Agent [candidate] (1.169 s) : 0, 1168723
Total [candidate] (11.122 s) : 0, 11121825
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~677efff2a1, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (693.661 ms) : 0, 693661
BytebuddyAgent [candidate] (696.737 ms) : 0, 696737
GlobalTracer [baseline] (241.879 ms) : 0, 241879
GlobalTracer [candidate] (243.088 ms) : 0, 243088
AppSec [baseline] (32.222 ms) : 0, 32222
AppSec [candidate] (32.45 ms) : 0, 32450
Debugger [baseline] (6.374 ms) : 0, 6374
Debugger [candidate] (6.441 ms) : 0, 6441
Remote Config [baseline] (722.375 µs) : 0, 722
Remote Config [candidate] (710.849 µs) : 0, 711
Telemetry [baseline] (9.342 ms) : 0, 9342
Telemetry [candidate] (9.295 ms) : 0, 9295
Flare Poller [baseline] (8.666 ms) : 0, 8666
Flare Poller [candidate] (10.307 ms) : 0, 10307
section appsec
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (722.263 ms) : 0, 722263
BytebuddyAgent [candidate] (717.743 ms) : 0, 717743
GlobalTracer [baseline] (235.596 ms) : 0, 235596
GlobalTracer [candidate] (234.343 ms) : 0, 234343
IAST [baseline] (24.75 ms) : 0, 24750
IAST [candidate] (24.546 ms) : 0, 24546
AppSec [baseline] (175.67 ms) : 0, 175670
AppSec [candidate] (175.165 ms) : 0, 175165
Debugger [baseline] (6.138 ms) : 0, 6138
Debugger [candidate] (6.044 ms) : 0, 6044
Remote Config [baseline] (651.124 µs) : 0, 651
Remote Config [candidate] (634.466 µs) : 0, 634
Telemetry [baseline] (8.452 ms) : 0, 8452
Telemetry [candidate] (8.387 ms) : 0, 8387
Flare Poller [baseline] (4.011 ms) : 0, 4011
Flare Poller [candidate] (3.89 ms) : 0, 3890
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (813.561 ms) : 0, 813561
BytebuddyAgent [candidate] (815.369 ms) : 0, 815369
GlobalTracer [baseline] (231.399 ms) : 0, 231399
GlobalTracer [candidate] (231.941 ms) : 0, 231941
IAST [baseline] (26.406 ms) : 0, 26406
IAST [candidate] (26.498 ms) : 0, 26498
AppSec [baseline] (35.042 ms) : 0, 35042
AppSec [candidate] (35.085 ms) : 0, 35085
Debugger [baseline] (6.123 ms) : 0, 6123
Debugger [candidate] (6.165 ms) : 0, 6165
Remote Config [baseline] (621.887 µs) : 0, 622
Remote Config [candidate] (618.243 µs) : 0, 618
Telemetry [baseline] (8.566 ms) : 0, 8566
Telemetry [candidate] (8.618 ms) : 0, 8618
Flare Poller [baseline] (4.213 ms) : 0, 4213
Flare Poller [candidate] (4.146 ms) : 0, 4146
section profiling
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (720.128 ms) : 0, 720128
BytebuddyAgent [candidate] (725.353 ms) : 0, 725353
GlobalTracer [baseline] (217.58 ms) : 0, 217580
GlobalTracer [candidate] (218.816 ms) : 0, 218816
AppSec [baseline] (32.626 ms) : 0, 32626
AppSec [candidate] (32.906 ms) : 0, 32906
Debugger [baseline] (6.452 ms) : 0, 6452
Debugger [candidate] (7.276 ms) : 0, 7276
Remote Config [baseline] (701.853 µs) : 0, 702
Remote Config [candidate] (715.638 µs) : 0, 716
Telemetry [baseline] (16.586 ms) : 0, 16586
Telemetry [candidate] (15.241 ms) : 0, 15241
Flare Poller [baseline] (4.196 ms) : 0, 4196
Flare Poller [candidate] (5.024 ms) : 0, 5024
ProfilingAgent [baseline] (106.92 ms) : 0, 106920
ProfilingAgent [candidate] (109.038 ms) : 0, 109038
Profiling [baseline] (107.632 ms) : 0, 107632
Profiling [candidate] (109.621 ms) : 0, 109621
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~677efff2a1, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.015 s) : 0, 1014508
Total [baseline] (8.706 s) : 0, 8706232
Agent [candidate] (1.019 s) : 0, 1019176
Total [candidate] (8.673 s) : 0, 8673237
section iast
Agent [baseline] (1.167 s) : 0, 1167192
Total [baseline] (9.328 s) : 0, 9327558
Agent [candidate] (1.149 s) : 0, 1148925
Total [candidate] (9.299 s) : 0, 9299008
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~677efff2a1, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (692.335 ms) : 0, 692335
BytebuddyAgent [candidate] (693.508 ms) : 0, 693508
GlobalTracer [baseline] (241.219 ms) : 0, 241219
GlobalTracer [candidate] (242.292 ms) : 0, 242292
AppSec [baseline] (32.477 ms) : 0, 32477
AppSec [candidate] (32.437 ms) : 0, 32437
Debugger [baseline] (6.4 ms) : 0, 6400
Debugger [candidate] (6.412 ms) : 0, 6412
Remote Config [baseline] (707.211 µs) : 0, 707
Remote Config [candidate] (704.055 µs) : 0, 704
Telemetry [baseline] (9.258 ms) : 0, 9258
Telemetry [candidate] (9.46 ms) : 0, 9460
Flare Poller [baseline] (9.563 ms) : 0, 9563
Flare Poller [candidate] (11.716 ms) : 0, 11716
section iast
crashtracking [baseline] (1.493 ms) : 0, 1493
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (827.396 ms) : 0, 827396
BytebuddyAgent [candidate] (813.791 ms) : 0, 813791
GlobalTracer [baseline] (234.456 ms) : 0, 234456
GlobalTracer [candidate] (231.365 ms) : 0, 231365
IAST [baseline] (26.901 ms) : 0, 26901
IAST [candidate] (26.352 ms) : 0, 26352
AppSec [baseline] (35.685 ms) : 0, 35685
AppSec [candidate] (35.169 ms) : 0, 35169
Debugger [baseline] (6.178 ms) : 0, 6178
Debugger [candidate] (6.063 ms) : 0, 6063
Remote Config [baseline] (632.659 µs) : 0, 633
Remote Config [candidate] (618.45 µs) : 0, 618
Telemetry [baseline] (8.704 ms) : 0, 8704
Telemetry [candidate] (8.58 ms) : 0, 8580
Flare Poller [baseline] (4.207 ms) : 0, 4207
Flare Poller [candidate] (4.192 ms) : 0, 4192
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~677efff2a1, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (36.097 ms) : 35809, 36385
. : milestone, 36097,
appsec (49.247 ms) : 48801, 49693
. : milestone, 49247,
code_origins (45.985 ms) : 45583, 46386
. : milestone, 45985,
iast (45.095 ms) : 44704, 45485
. : milestone, 45095,
profiling (50.936 ms) : 50465, 51407
. : milestone, 50936,
tracing (45.065 ms) : 44684, 45445
. : milestone, 45065,
section candidate
no_agent (37.359 ms) : 37055, 37664
. : milestone, 37359,
appsec (48.522 ms) : 48067, 48977
. : milestone, 48522,
code_origins (45.579 ms) : 45189, 45969
. : milestone, 45579,
iast (42.51 ms) : 42146, 42874
. : milestone, 42510,
profiling (51.044 ms) : 50577, 51512
. : milestone, 51044,
tracing (43.23 ms) : 42867, 43593
. : milestone, 43230,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~677efff2a1, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (4.305 ms) : 4256, 4353
. : milestone, 4305,
iast (10.307 ms) : 10128, 10486
. : milestone, 10307,
iast_FULL (14.401 ms) : 14112, 14690
. : milestone, 14401,
iast_GLOBAL (10.508 ms) : 10313, 10704
. : milestone, 10508,
profiling (8.583 ms) : 8443, 8723
. : milestone, 8583,
tracing (7.795 ms) : 7676, 7915
. : milestone, 7795,
section candidate
no_agent (4.416 ms) : 4367, 4465
. : milestone, 4416,
iast (10.364 ms) : 10188, 10540
. : milestone, 10364,
iast_FULL (14.287 ms) : 14004, 14571
. : milestone, 14287,
iast_GLOBAL (10.265 ms) : 10084, 10445
. : milestone, 10265,
profiling (8.852 ms) : 8717, 8988
. : milestone, 8852,
tracing (8.008 ms) : 7885, 8130
. : milestone, 8008,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~677efff2a1, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.706 ms) : 3488, 3925
. : milestone, 3706,
iast (2.211 ms) : 2148, 2275
. : milestone, 2211,
iast_GLOBAL (2.237 ms) : 2173, 2300
. : milestone, 2237,
profiling (2.062 ms) : 2010, 2115
. : milestone, 2062,
tracing (2.016 ms) : 1966, 2065
. : milestone, 2016,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.703 ms) : 3485, 3920
. : milestone, 3703,
iast (2.199 ms) : 2135, 2262
. : milestone, 2199,
iast_GLOBAL (2.236 ms) : 2172, 2299
. : milestone, 2236,
profiling (2.069 ms) : 2017, 2122
. : milestone, 2069,
tracing (2.019 ms) : 1970, 2068
. : milestone, 2019,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~677efff2a1, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (15.552 s) : 15552000, 15552000
. : milestone, 15552000,
appsec (14.911 s) : 14911000, 14911000
. : milestone, 14911000,
iast (18.361 s) : 18361000, 18361000
. : milestone, 18361000,
iast_GLOBAL (18.012 s) : 18012000, 18012000
. : milestone, 18012000,
profiling (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
tracing (15.249 s) : 15249000, 15249000
. : milestone, 15249000,
section candidate
no_agent (15.527 s) : 15527000, 15527000
. : milestone, 15527000,
appsec (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
iast (18.442 s) : 18442000, 18442000
. : milestone, 18442000,
iast_GLOBAL (18.252 s) : 18252000, 18252000
. : milestone, 18252000,
profiling (15.07 s) : 15070000, 15070000
. : milestone, 15070000,
tracing (15.061 s) : 15061000, 15061000
. : milestone, 15061000,
|
bric3
approved these changes
Oct 10, 2025
bric3
changed the title
SupportedConfigPlugin
bric3
reviewed
Oct 10, 2025
| java.srcDir(generateTask) | ||
| } | ||
|
|
||
| targetProject.tasks.named("javadoc") { |
There was a problem hiding this comment.
thought: Making javadoc depends on generate task seems odd, have you tried with processResources ?
There was a problem hiding this comment.
@bric3 Hmm that didn't seem to work. I noticed in the task ordering of assemble that utils:config-utils:javadoc executes after both generateSupportedConfigurations and processResources. Do you have any ideas on why this still doesn't work?
There was a problem hiding this comment.
Nothing comes immediately to mind, I need to look into that.
task ordering
You should think in terms of graph, or task dependencies :)
amarziali
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Following a discussion on Slack regarding #9604, this PR moves the task dependency from
:utils:config-utils:build.gradle.ktsto the task itself. This decouples the dependency from the location where the task is being executed to the task itself.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]