Skip to content

Moving config gen task dependency from Gradle build file to SupportedConfigPlugin #9714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2025
Merged

Moving config gen task dependency from Gradle build file to SupportedConfigPlugin #9714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
483dd86
moving task dependency from gradle file to task
mhlidd Oct 9, 2025
677efff
removing comment
mhlidd Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions buildSrc/src/main/kotlin/datadog/gradle/plugin/config/SupportedConfigPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,9 @@ class SupportedConfigPlugin : Plugin<Project> {
sourceset.configure {
java.srcDir(generateTask)
}

targetProject.tasks.named("javadoc") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Making javadoc depends on generate task seems odd, have you tried with processResources ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bric3 Hmm that didn't seem to work. I noticed in the task ordering of assemble that utils:config-utils:javadoc executes after both generateSupportedConfigurations and processResources. Do you have any ideas on why this still doesn't work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing comes immediately to mind, I need to look into that.

task ordering

You should think in terms of graph, or task dependencies :)

dependsOn(generateTask)
}
}
}
4 changes: 0 additions & 4 deletions utils/config-utils/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,3 @@ dependencies {
testImplementation(project(":utils:test-utils"))
testImplementation("org.snakeyaml:snakeyaml-engine:2.9")
}

tasks.named("javadoc") {
dependsOn("generateSupportedConfigurations")
}