Skip to content

Conversation

@ajgajg1134
Copy link

@ajgajg1134 ajgajg1134 commented Oct 10, 2025

What Does This Do

Add top_level to debug span output when the span is marked top_level

Motivation

We already mark measured spans, but those aren't the only spans that have stats calculated. The missing field here would have made a recent debugging of a customer issue easier

Additional Notes

This is my first time contributing to this repo so I might have missed some steps or something here :P. I lack permissions to set labels myself too so I can't fully follow the below checklist

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Comment on lines +340 to +343
topLevelContext.isTopLevel() == true
topLevelContext.toString().contains("*top_level*") == true
nonTopLevelContext.isTopLevel() == false
nonTopLevelContext.toString().contains("*top_level*") == false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spock will assert booleans out of the box, so I think this can be like:

Suggested change
topLevelContext.isTopLevel() == true
topLevelContext.toString().contains("*top_level*") == true
nonTopLevelContext.isTopLevel() == false
nonTopLevelContext.toString().contains("*top_level*") == false
topLevelContext.isTopLevel()
topLevelContext.toString().contains("*top_level*")
!nonTopLevelContext.isTopLevel()
!nonTopLevelContext.toString().contains("*top_level*")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants