Skip to content

Add top_level to span debug output #9728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add top_level to span debug output #9728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12c8524
Add top_level to span debug output
ajgajg1134 Oct 10, 2025
922ebe3
add test for top_level in output
ajgajg1134 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,9 @@ public String toString() {
if (measured) {
s.append(" *measured*");
}
if (topLevel) {
s.append(" *top_level*");
}

synchronized (unsafeTags) {
s.append(" tags=").append(new TreeMap<>(getTags()));
Expand Down
31 changes: 31 additions & 0 deletions dd-trace-core/src/test/groovy/datadog/trace/core/DDSpanContextTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,37 @@ class DDSpanContextTest extends DDCoreSpecification {
context.toString().contains("id=-") == false
}

def "toString includes top_level flag"() {
setup:
def parent = tracer.buildSpan("parentOperation")
.withServiceName("parentService")
.withResourceName("parentResource")
.start()

// Child span with different service name should be top-level
def topLevelSpan = tracer.buildSpan("childOperation")
.withServiceName("childService")
.withResourceName("childResource")
.asChildOf(parent.context())
.start()

// Child span with same service name should not be top-level
def nonTopLevelSpan = tracer.buildSpan("childOperation2")
.withServiceName("parentService")
.withResourceName("childResource2")
.asChildOf(parent.context())
.start()

def topLevelContext = topLevelSpan.context() as DDSpanContext
def nonTopLevelContext = nonTopLevelSpan.context() as DDSpanContext

expect:
topLevelContext.isTopLevel() == true
topLevelContext.toString().contains("*top_level*") == true
nonTopLevelContext.isTopLevel() == false
nonTopLevelContext.toString().contains("*top_level*") == false
Comment on lines +340 to +343
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spock will assert booleans out of the box, so I think this can be like:

Suggested change
topLevelContext.isTopLevel() == true
topLevelContext.toString().contains("*top_level*") == true
nonTopLevelContext.isTopLevel() == false
nonTopLevelContext.toString().contains("*top_level*") == false
topLevelContext.isTopLevel()
topLevelContext.toString().contains("*top_level*")
!nonTopLevelContext.isTopLevel()
!nonTopLevelContext.toString().contains("*top_level*")

}

static void assertTagmap(Map source, Map comparison, boolean removeThread = false) {
def sourceWithoutCommonTags = new HashMap(source)
sourceWithoutCommonTags.remove("runtime-id")
Expand Down
Loading