-
Notifications
You must be signed in to change notification settings - Fork 351
rename master to main #3407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename master to main #3407
Conversation
Overall package sizeSelf size: 8.77 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3407 +/- ##
=======================================
Coverage 80.94% 80.94%
=======================================
Files 488 488
Lines 21851 21851
=======================================
Hits 17688 17688
Misses 4163 4163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
astuyve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 from Serverless
nsavoire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for profiling !
tlhunter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth sharing the command that developers will need to run locally to get things square. Like, they should probably delete master, checkout main, track the remote.
szegedi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad we're doing this!
|
@tlhunter I've added that in the PR description. Since this should only need to be done once, I don't think it warrants being included elsewhere. |
23e0de6
7987702 to
23e0de6
Compare
duncanista
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally! 😈
|
Strange. Not sure where that review request came from. I guess it auto-triggered somehow when I force pushed master to fix the recent accidental merge? 🤔 |
|
This pull request has been marked as stale due to 90 days of inactivity. |
23e0de6 to
cef02a7
Compare
|
I just updated the PR. Please have another look |
This makes the appropriate changes in CI files, readme, etc., to rename the master branch to main. Once this is merged, the branch should _immediately_ be renamed, which should also re-home PRs agains main. [GitHub provides some details on this process](https://github.com/github/renaming). Co-authored-by: Ruben Bridgewater <[email protected]>
Datadog ReportBranch report: ✅ 0 Failed, 663 Passed, 0 Skipped, 10m 31.12s Total Time |
cef02a7 to
5ff6ff8
Compare
|
Moving this to draft because it needs quite a huge rebase, or potentially a re-do. |
|
Superseded |
This makes the appropriate changes in CI files, readme, etc., to rename the master branch to main.
Once this is merged, the branch should immediately be renamed, which should also re-home PRs against main. GitHub provides some details on this process. Note the following from that page:
Local branches should be changed, after this has been merged and the branch has been renamed: