- 
                Notifications
    You must be signed in to change notification settings 
- Fork 468
chore(er): remove deprecated variable #15060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.0-breaking-changes
Are you sure you want to change the base?
Conversation
| 
  | 
| Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 235 ± 2 ms. The average import time from base is: 238 ± 2 ms. The import time difference between this PR and base is: -2.18 ± 0.07 ms. Import time breakdownThe following import paths have grown: 
             | 
| Performance SLOsComparing candidate er/remove-deprecated-var (063fccd) with baseline 4.0-breaking-changes (eb90319) 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.8% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.0% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ add_inplace_noaspectTime: ✅ 0.319µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +1.8% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -2.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ bytearray_aspectTime: ✅ 1.371µs (SLO: <10.000µs 📉 -86.3%) vs baseline: +1.1% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 1.521µs (SLO: <10.000µs 📉 -84.8%) vs baseline: +0.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 0.607µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -1.1% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 0.483µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.2% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ bytes_aspectTime: ✅ 1.294µs (SLO: <10.000µs 📉 -87.1%) vs baseline: +0.3% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.1% ✅ bytes_noaspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ bytesio_aspectTime: ✅ 1.352µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +0.8% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.0%) vs baseline: ~same Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ capitalize_aspectTime: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.1% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 0.436µs (SLO: <10.000µs 📉 -95.6%) vs baseline: -0.3% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ casefold_aspectTime: ✅ 0.734µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.5% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.371µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 0.723µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 0.420µs (SLO: <10.000µs 📉 -95.8%) vs baseline: ~same Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ encode_aspectTime: ✅ 0.710µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.3% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ encode_noaspectTime: ✅ 0.399µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.6% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ format_aspectTime: ✅ 3.386µs (SLO: <10.000µs 📉 -66.1%) vs baseline: -1.2% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 4.204µs (SLO: <10.000µs 📉 -58.0%) vs baseline: 📈 +14.2% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ format_map_noaspectTime: ✅ 0.772µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.8% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 0.593µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -1.1% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.1% ✅ index_aspectTime: ✅ 0.355µs (SLO: <10.000µs 📉 -96.5%) vs baseline: -0.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ index_noaspectTime: ✅ 0.280µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.9% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ join_aspectTime: ✅ 1.349µs (SLO: <10.000µs 📉 -86.5%) vs baseline: -0.3% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.0% ✅ join_noaspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.2% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 2.583µs (SLO: <20.000µs 📉 -87.1%) vs baseline: ~same Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.7% ✅ ljust_noaspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.4% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 2.208µs (SLO: <10.000µs 📉 -77.9%) vs baseline: +0.4% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 0.371µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.4% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0% ✅ lstrip_aspectTime: ✅ 2.184µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -1.7% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 0.386µs (SLO: <10.000µs 📉 -96.1%) vs baseline: -0.5% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 1.000µs (SLO: <10.000µs 📉 -90.0%) vs baseline: +0.2% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.557µs (SLO: <10.000µs 📉 -84.4%) vs baseline: -0.3% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.983µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +0.9% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.7% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.224µs (SLO: <10.000µs 📉 -87.8%) vs baseline: -0.2% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ modulo_noaspectTime: ✅ 0.633µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +1.2% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0% ✅ replace_aspectTime: ✅ 4.922µs (SLO: <10.000µs 📉 -50.8%) vs baseline: ~same Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 0.462µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.7% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 0.907µs (SLO: <10.000µs 📉 -90.9%) vs baseline: ~same Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ repr_noaspectTime: ✅ 0.414µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.3% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 1.899µs (SLO: <20.000µs 📉 -90.5%) vs baseline: -1.2% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ rstrip_noaspectTime: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.5% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.446µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.4% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ stringio_aspectTime: ✅ 1.644µs (SLO: <10.000µs 📉 -83.6%) vs baseline: +4.1% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 0.713µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.4% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 2.204µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -0.3% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.6% ✅ strip_noaspectTime: ✅ 0.388µs (SLO: <10.000µs 📉 -96.1%) vs baseline: -0.5% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ swapcase_aspectTime: ✅ 2.429µs (SLO: <10.000µs 📉 -75.7%) vs baseline: +1.5% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 0.535µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -0.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 2.472µs (SLO: <10.000µs 📉 -75.3%) vs baseline: +6.4% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.7% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 3.226µs (SLO: <10.000µs 📉 -67.7%) vs baseline: -0.2% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ translate_noaspectTime: ✅ 1.042µs (SLO: <10.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.8% ✅ upper_aspectTime: ✅ 2.213µs (SLO: <10.000µs 📉 -77.9%) vs baseline: +0.9% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.480ms (SLO: <22.300ms -8.2%) vs baseline: -0.3% Memory: ✅ 66.434MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.346ms (SLO: <1.450ms -7.2%) vs baseline: +0.3% Memory: ✅ 64.584MB (SLO: <67.000MB -3.6%) vs baseline: +4.8% ✅ iastTime: ✅ 20.504ms (SLO: <22.250ms -7.8%) vs baseline: ~same Memory: ✅ 66.453MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.506ms (SLO: <16.550ms -6.3%) vs baseline: +0.6% Memory: ✅ 54.083MB (SLO: <54.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.639ms (SLO: <21.750ms -5.1%) vs baseline: +0.5% Memory: ✅ 66.453MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 25.541ms (SLO: <28.200ms -9.4%) vs baseline: +0.5% Memory: ✅ 67.473MB (SLO: <69.500MB -2.9%) vs baseline: +4.6% ✅ tracerTime: ✅ 20.466ms (SLO: <21.750ms -5.9%) vs baseline: -0.4% Memory: ✅ 66.439MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.722ms (SLO: <23.500ms -3.3%) vs baseline: +0.3% Memory: ✅ 67.849MB (SLO: <68.000MB 🟡 -0.2%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.364ms (SLO: <21.500ms -9.9%) vs baseline: +0.3% Memory: ✅ 66.433MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.626ms (SLO: <17.500ms -5.0%) vs baseline: -0.2% Memory: ✅ 66.473MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.452ms (SLO: <21.750ms -6.0%) vs baseline: -0.1% Memory: ✅ 72.352MB (SLO: <72.500MB 🟡 -0.2%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.479ms (SLO: <19.650ms -6.0%) vs baseline: ~same Memory: ✅ 66.446MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.821ms (SLO: <20.100ms -6.4%) vs baseline: ~same Memory: ✅ 66.446MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.237ms (SLO: <21.500ms -5.9%) vs baseline: ~same Memory: ✅ 66.440MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 20.332ms (SLO: <22.000ms -7.6%) vs baseline: -0.2% Memory: ✅ 66.473MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.327ms (SLO: <19.850ms -7.7%) vs baseline: +1.7% Memory: ✅ 66.474MB (SLO: <66.500MB 🟡 ~same) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.071ms (SLO: <19.400ms -6.8%) vs baseline: ~same Memory: ✅ 66.471MB (SLO: <66.500MB 🟡 ~same) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.249ms (SLO: <19.450ms -6.2%) vs baseline: +0.8% Memory: ✅ 66.374MB (SLO: <66.500MB 🟡 -0.2%) vs baseline: +4.9% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.080ms (SLO: <2.300ms -9.6%) vs baseline: +0.3% Memory: ✅ 52.809MB (SLO: <53.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 2.100ms (SLO: <2.250ms -6.7%) vs baseline: +1.5% Memory: ✅ 52.770MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ tracer-enabledTime: ✅ 2.088ms (SLO: <2.300ms -9.2%) vs baseline: +0.4% Memory: ✅ 52.888MB (SLO: <53.500MB 🟡 -1.1%) vs baseline: +5.0% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.599ms (SLO: <4.750ms -3.2%) vs baseline: ~same Memory: ✅ 62.698MB (SLO: <65.000MB -3.5%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.641ms (SLO: <6.750ms 🟡 -1.6%) vs baseline: +0.3% Memory: ✅ 62.777MB (SLO: <65.000MB -3.4%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.604ms (SLO: <4.750ms -3.1%) vs baseline: +0.3% Memory: ✅ 62.738MB (SLO: <65.000MB -3.5%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: +0.1% Memory: ✅ 45.318MB (SLO: <47.000MB -3.6%) vs baseline: +4.5% ✅ iast-getTime: ✅ 1.855ms (SLO: <2.000ms -7.2%) vs baseline: -0.3% Memory: ✅ 42.369MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -9.0%) vs baseline: -0.2% Memory: ✅ 46.458MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.3% ✅ resource-renamingTime: ✅ 3.369ms (SLO: <3.650ms -7.7%) vs baseline: ~same Memory: ✅ 53.006MB (SLO: <53.500MB 🟡 -0.9%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.357ms (SLO: <3.650ms -8.0%) vs baseline: -0.2% Memory: ✅ 52.986MB (SLO: <53.500MB 🟡 -1.0%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.358ms (SLO: <3.650ms -8.0%) vs baseline: ~same Memory: ✅ 59.119MB (SLO: <60.000MB 🟡 -1.5%) vs baseline: +5.2% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.962ms (SLO: <4.200ms -5.7%) vs baseline: ~same Memory: ✅ 62.875MB (SLO: <66.000MB -4.7%) vs baseline: +4.7% ✅ iast-enabledTime: ✅ 2.444ms (SLO: <2.800ms 📉 -12.7%) vs baseline: -0.4% Memory: ✅ 59.336MB (SLO: <60.000MB 🟡 -1.1%) vs baseline: +4.6% ✅ tracer-enabledTime: ✅ 2.067ms (SLO: <2.250ms -8.1%) vs baseline: -0.4% Memory: ✅ 52.986MB (SLO: <54.500MB -2.8%) vs baseline: +4.9% 
 | 
| Depends on DataDog/system-tests#5622 | 
No description provided.