chore: remove deprecated ER variable #5622
Open
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
P403n1x87
force-pushed
the
chore/remove-deprecated-er-var
branch
from
b878bf5 to
8bc334d
Compare
P403n1x87
force-pushed
the
chore/remove-deprecated-er-var
branch
from
8bc334d to
e3bd952
Compare
cbeauchesne
approved these changes
Oct 28, 2025
The support for this old variable will be dropped in v4. The new variable has been around for a long time and all the versions that we still support have it, so the deprecated one is not needed as long as we're testing versions for which we still offer support. |
tylfin
reviewed
Oct 31, 2025
| "DD_ERROR_TRACKING_REPORT_HANDLED_ERRORS_ENABLED_MODULES": "error_tracking_report_handled_errors_enabled_modules", | ||
| "DD_ERROR_TRACKING_REPORT_HANDLED_ERRORS_LOGGER": "error_tracking_report_handled_errors_logger", | ||
| "DD_EXCEPTION_DEBUGGING_CAPTURE_FULL_CALLSTACK_ENABLED": "exception_debugging_capture_full_callstack_enabled", | ||
| "DD_EXCEPTION_DEBUGGING_ENABLED": "exception_replay_enabled", |
There was a problem hiding this comment.
I think this file is meant to be 1:1 with the dd-go/config_norm_rules.json, so we should likely leave these, especially since older tracers will continue to emit the exception debugging value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
System tests are still using the deprecated
DD_EXCEPTION_DEBUGGING_ENABLEDvariable.Changes
We remove any references of it and replace it with the official one where appropriate.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present