Skip to content

Conversation

TheBestTvarynka
Copy link
Collaborator

Hi,
This PR contains server-side Kerberos implementation and the existing Kerberos client refactoring. See more details in these PRs:

The implementation was tested using FreeRDP and mstsc (with the help of MsRdpEx).

@TheBestTvarynka TheBestTvarynka self-assigned this Jul 4, 2025
@CBenoit
Copy link
Member

CBenoit commented Jul 4, 2025

@TheBestTvarynka Could you change the commit type of feat(sspi): server-side Kerberos fixes to use fix instead? It will go in the wrong session of the changelog otherwise
Also feel free to adjust any other commit you may want to render differently in the changelog.

@TheBestTvarynka
Copy link
Collaborator Author

Could you change the commit type of feat(sspi): server-side Kerberos fixes to use fix instead?

sure. I will do it after I fix merge conflicts

@TheBestTvarynka TheBestTvarynka force-pushed the dev/server-side-kerberos branch from f40a506 to 26153bf Compare July 7, 2025 13:43
@TheBestTvarynka
Copy link
Collaborator Author

TheBestTvarynka commented Jul 7, 2025

@CBenoit I fixed the commit message and merge conflicts. Also, I performed a small dev-testing using FreeRDP just to make sure that I did not break anything during the bug fix. It still works:

image

So, you can review and merge this RP 😊

@TheBestTvarynka TheBestTvarynka marked this pull request as ready for review July 7, 2025 14:38
@TheBestTvarynka TheBestTvarynka requested a review from CBenoit July 7, 2025 14:38
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent job!!

@CBenoit CBenoit merged commit 4bbe407 into master Jul 7, 2025
43 checks passed
@CBenoit CBenoit deleted the dev/server-side-kerberos branch July 7, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants