Skip to content

Conversation

TheBestTvarynka
Copy link
Collaborator

Hi,
I fixed Kerberos server WRAP token generation and validation. I discovered these problems during dev-testing using mstscex.

@TheBestTvarynka TheBestTvarynka self-assigned this Jul 4, 2025
@TheBestTvarynka TheBestTvarynka requested a review from CBenoit July 4, 2025 15:05
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks!

By the way, would it make sense to add regression tests for this kind of stuff?

@CBenoit CBenoit merged commit f40a506 into dev/server-side-kerberos Jul 4, 2025
42 checks passed
@CBenoit CBenoit deleted the fix/kerberos-server-wrap-token branch July 4, 2025 15:33
@TheBestTvarynka
Copy link
Collaborator Author

TheBestTvarynka commented Jul 4, 2025

By the way, would it make sense to add regression tests for this kind of stuff?

These changes improved the Kerberos client implementation: stricter checks during the acceptance of incoming messages. So, previously invalid messages will no longer be accepted, and our existing tests will catch such errors. This is why I added the fake_server_properties function: without it, existing tests fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants