Skip to content

Conversation

devolutionsbot
Copy link
Contributor

🤖 New release

  • sspi: 0.15.14 -> 0.15.15 (✓ API compatible changes)
Changelog

sspi

[0.15.15] - 2025-07-07

Features

Bug Fixes


This PR was generated with release-plz.

@TheBestTvarynka
Copy link
Collaborator

@CBenoit I think the new version should be 0.16. In the least PR, I made the accept_security_context function async (now it returns a generator). This is a breaking change. What do you think?

@CBenoit
Copy link
Member

CBenoit commented Jul 7, 2025

I think the new version should be 0.16. In the least PR, I made the accept_security_context function async (now it returns a generator). This is a breaking change. What do you think?

Makes sense, but are you referring to this function?

pub async fn accept_security_context(

It seems that it was added, and not modified, unless I’m missing something 🤔

But anyway, it’s still a bit risky to not perform a major bump given the big number of changes, so I rather agree with a 0.16 bump.

By the way, it’s possible to specify that a commit is bringing a breaking change following the conventional commit spec: https://www.conventionalcommits.org/en/v1.0.0/
It would be best to properly document that using a ! after the type/scope, or adding the BREAKING CHANGE: footer along a description of the breakage.

@CBenoit CBenoit enabled auto-merge (squash) July 7, 2025 20:10
@TheBestTvarynka
Copy link
Collaborator

By the way, it’s possible to specify that a commit is bringing a breaking change following the conventional commit spec: conventionalcommits.org/en/v1.0.0

Got it! 👍

@TheBestTvarynka
Copy link
Collaborator

Makes sense, but are you referring to this function?

I am talking about this change: https://github.com/Devolutions/sspi-rs/pull/440/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759L1270-R1283

@CBenoit
Copy link
Member

CBenoit commented Jul 8, 2025

Makes sense, but are you referring to this function?

I am talking about this change: https://github.com/Devolutions/sspi-rs/pull/440/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759L1270-R1283

Indeed! This to be a breaking change to me, but the tool (cargo-semver-checks) didn’t catch it! Thank you for pointing it

@CBenoit CBenoit merged commit f2dcfdd into master Jul 8, 2025
42 checks passed
@CBenoit CBenoit deleted the release-plz/2025-07-07T19-24-18Z branch July 8, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants