-
Notifications
You must be signed in to change notification settings - Fork 25
chore(release): prepare for publishing #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@CBenoit I think the new version should be 0.16. In the least PR, I made the |
Makes sense, but are you referring to this function? sspi-rs/src/kerberos/server/mod.rs Line 105 in 4bbe407
It seems that it was added, and not modified, unless I’m missing something 🤔 But anyway, it’s still a bit risky to not perform a major bump given the big number of changes, so I rather agree with a 0.16 bump. By the way, it’s possible to specify that a commit is bringing a breaking change following the conventional commit spec: https://www.conventionalcommits.org/en/v1.0.0/ |
Got it! 👍 |
I am talking about this change: https://github.com/Devolutions/sspi-rs/pull/440/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759L1270-R1283 |
Indeed! This to be a breaking change to me, but the tool (cargo-semver-checks) didn’t catch it! Thank you for pointing it |
🤖 New release
sspi
: 0.15.14 -> 0.15.15 (✓ API compatible changes)Changelog
sspi
This PR was generated with release-plz.