-
Notifications
You must be signed in to change notification settings - Fork 1
Register CLEM data in ISPyB #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…te them from ISPyB database tables
* Linked 'CLEMImageSeries' to 'DataCollectionGroup' and 'GridSquare' * Tried modern type hinting notation in 'CLEMImageSeries' table * Added new columns to 'CLEMImageSeries' to keep track of image search string (for globbing images with) and type of dataset (i.e., atlas or grid square) * Removed 'composite_image' column from 'CLEMImageSeries'
…n_and_merge_results' workflow
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
==========================================
+ Coverage 36.94% 38.24% +1.29%
==========================================
Files 97 97
Lines 11459 11593 +134
Branches 1510 1528 +18
==========================================
+ Hits 4234 4434 +200
+ Misses 7063 6964 -99
- Partials 162 195 +33 🚀 New features to boost your workflow:
|
…of image shape, pixel size, and spatial location on grid
…ctions for the sake of readability
… scaled down information about the grid squares being registered
…reprocess' workflow instead, so that the grid square registration and updating functions just register the values as-is
0b55f57 to
2c1ac4f
Compare
c77516e to
d206593
Compare
d12a674 to
6bb3e69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems fine, as long as you're happy it works
| pixels_x: Optional[int] = Field(default=None) | ||
| pixels_y: Optional[int] = Field(default=None) | ||
| pixel_size: Optional[float] = Field(default=None) | ||
| units: Optional[str] = Field(default=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need the units in the database? I can't see they are used anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a valid point. I included it as a just-in-case, so I'll revisit this in the future if no new workflows end up using this column.
6bb3e69 to
a62941c
Compare
7c7cce2 to
31b26f4
Compare
7917b40 to
72b2b1f
Compare
5c988b1 to
df1f732
Compare
…fey and ISPyB have happened
… is the last dataset to be registered
ba2d1d2 to
3abe4f6
Compare
Adds logic to register incoming CLEM data to both ISPyB and its mirror tables on Murfey.
CLEMImageSeriestable to keep track of image metadata needed for the ISPyB insert