-
Notifications
You must be signed in to change notification settings - Fork 1
Register CLEM data in ISPyB #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b3464bb
Create additional fluorescent-only and bright field-only composite im…
tieneupin 8641d38
Import Murfey database classes differently, to eventually differentia…
tieneupin f511242
'slot' should be optional
tieneupin c5aca0c
Updated Murfey database to integrate CLEM workflow with ISPyB
tieneupin c6fea87
Removed registration of composite image file path from 'register_alig…
tieneupin 09190be
Stored tag/name of data collection group in CLEMImageSeries table as …
tieneupin edba7eb
Added logic to create data collection group and atlas table entries f…
tieneupin 6fa10e3
Revert to using older annotated types
tieneupin 1b007fa
Added more database columns to 'CLEMImageSeries' table to keep track …
tieneupin 2387cdd
Broke 'register_preprocessing_results' workflow down into smaller fun…
tieneupin 836e016
Added new optional fields into 'GridSquareParameters' table to stored…
tieneupin 0d88293
Migrated logic for rescaling grid square values into the 'flush_spa_p…
tieneupin d7b33f3
Return failure result if unable to load Murfey session information
tieneupin 41f533a
Added logic to register non-atlas CLEM image series as grid squares
tieneupin 1cfb006
Included calculation of image dimensions (in pixels) as displayed on …
tieneupin 7967068
Added placeholders for the unit tests to register CLEM preprocessing …
tieneupin 4038cda
Added unit test for 'run' main function in 'register_preprocessing_re…
tieneupin 72b2b1f
Test workflow with actual Murfey and ISPyB databases
tieneupin df1f732
Pass messages to test in reverse order as well
tieneupin 406d510
More thorough test to verify that the database insertions on both Mur…
tieneupin 3abe4f6
Fixed bug with grid square registration not running if the CLEM atlas…
tieneupin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need the units in the database? I can't see they are used anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a valid point. I included it as a just-in-case, so I'll revisit this in the future if no new workflows end up using this column.