Skip to content

Conversation

bsb808
Copy link
Contributor

@bsb808 bsb808 commented Feb 25, 2022

Adds one more model - the Mark 48 heavy weight torpedo.

To test run

roslaunch dave_demo_launch dave_models.launch

You should see one additional model compared to #209 - the large torpedo shown here:

Screenshot from 2022-02-24 20-36-00

@bsb808
Copy link
Contributor Author

bsb808 commented Feb 25, 2022

A tagged both @quarkytale and @j-herman as potential reviewers. Just needs one review, but thought I'd see who has the time to take a look.

@bsb808 bsb808 added this to the 4.3.0 milestone Feb 25, 2022
@j-herman
Copy link
Contributor

I've got it. Nice easy way to ease into the morning :)

Copy link
Contributor

@j-herman j-herman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a torpedo. When lifted and dropped, rolls like a big heavy torpedo. All good here! Definitely a good call to mention the extended load time in the wiki as you mentioned in #220 - it surprised me.

@bsb808 bsb808 merged commit d36a52d into master Feb 25, 2022
@bsb808 bsb808 deleted the feature/bsb/moremodels branch February 25, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants