Skip to content

[Program Plugin] Search programs in PATH #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Nov 14, 2022
Merged

[Program Plugin] Search programs in PATH #1479

merged 38 commits into from
Nov 14, 2022

Conversation

VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor VictoriousRaptor commented Oct 17, 2022 •
edited
Loading

Resolves #116

Changes

  1. Add a option to allow Program plugin to search programs in PATH environment variable. Disabled by default (should it enabled by default?). And searching in PATH is not recursive because PATH itself is not recursive.
    图片

Tests

@VictoriousRaptor VictoriousRaptor changed the title Search programs in PATH [Program Plugin] Search programs in PATH Oct 17, 2022
@jjw24
Copy link
Member

jjw24 commented Oct 17, 2022

no maximum search depth limit

You mean the search preference in settings or maximum results?

@VictoriousRaptor
Copy link
Contributor Author

no maximum search depth limit

You mean the search preference in settings or maximum results?

The preference in settings.

@jjw24
Copy link
Member

jjw24 commented Oct 19, 2022

Just to confirm are we talking about the query search precision setting? Can you link me please.

@VictoriousRaptor
Copy link
Contributor Author

Just to confirm are we talking about the query search precision setting? Can you link me please.

https://github.com/VictoriousRaptor/Flow.Launcher/blob/2672460cc888a32907eeccdcc7e079dff6b88a67/Plugins/Flow.Launcher.Plugin.Program/Languages/en.xaml#L34

@VictoriousRaptor VictoriousRaptor added the enhancement New feature or request label Oct 29, 2022
@VictoriousRaptor VictoriousRaptor added this to the 1.10.0 milestone Oct 30, 2022
@VictoriousRaptor
Copy link
Contributor Author

#116

@VictoriousRaptor VictoriousRaptor linked an issue Oct 30, 2022 that may be closed by this pull request
Support PATH environment variables when searching for tools #116
Closed
@jjw24
Copy link
Member

jjw24 commented Nov 8, 2022

@VictoriousRaptor would you mind updating the description what's been tested please, and maybe remove the problems section if they are no longer please.

@jjw24 jjw24 added the review in progress Indicates that a review is in progress for this PR label Nov 8, 2022
jjw24
jjw24 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Nov 14, 2022
@jjw24 jjw24 merged commit f8b009e into Flow-Launcher:dev Nov 14, 2022
@VictoriousRaptor VictoriousRaptor mentioned this pull request Nov 17, 2022
Merged
4 tasks
@jjw24 jjw24 mentioned this pull request Dec 12, 2022
Merged
@VictoriousRaptor VictoriousRaptor deleted the SearchProgramsInPATH branch December 30, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjw24 jjw24 jjw24 approved these changes

@onesounds onesounds Awaiting requested review from onesounds

@taooceros taooceros Awaiting requested review from taooceros

Assignees

@VictoriousRaptor VictoriousRaptor

Labels

enhancement New feature or request

Projects

Work In Progress
Archived in project

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

Support PATH environment variables when searching for tools

3 participants

@VictoriousRaptor @jjw24 @onesounds