-
-
Notifications
You must be signed in to change notification settings - Fork 448
[Dev][Program Plugin] Optimize program indexing performance #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
open parent dir of .lnk instead of its target
Try to avoid situation like http matches https
</system:String> | ||
<system:String x:Key="flowlauncher_plugin_program_protocol_tooltip"> | ||
Insert protocols of .url files you want to index. Protocols should be separated by ';'. (ex>ftp;netflix) | ||
Insert protocols of .url files you want to index. Protocols should be separated by ';', and should end with "//". (ex>ftp://;mailto://) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want really parse the URL. So try to tell users how to avoid situaions like http
actually matches a URL starts with https
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not parse it? Uri.TryParse is not expensive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because for steam games their URL scheme is steam://app/
rather than steam://
so parsing the URL for protocol is not enough.
This is a optimization of #1479. PATH can be a subfolder of custom program sources. It makes unnecessary I/O when enabled PATH indexing because indexing for custom sources is recursive. And a custom source can be a subfolder of another.
And let file change watcher only watch files that can be indexed (
exe
, `lnk', ...).Changes
Tests