-
-
Notifications
You must be signed in to change notification settings - Fork 448
Fix Setting Window Designs #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
</Target> | ||
|
||
<Target Name="RemoveDuplicateAnalyzers" BeforeTargets="CoreCompile"> | ||
<!-- Work around https://github.com/dotnet/wpf/issues/6792 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This work around is no longer required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. It should have been fixed in the latest version.
<StartupObject /> | ||
<GenerateAssemblyInfo>false</GenerateAssemblyInfo> | ||
<AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath> | ||
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two properties are not necessary now that the ci fix is merged in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i will remove them.
…ow.Launcher into CheckboxesToToggle4
What's the PR
- Seperate style to other file from SettingWindow.Xaml (SettingWindow.xaml was too long)Let's apply this task when working with valonia.Before
After
Fix Plugins Designs
Fix Clickable Area

Fix Hover Color
Fix Store with Darkmode


Why?
Test Case