Skip to content

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Nov 11, 2022

What's the PR
- Seperate style to other file from SettingWindow.Xaml (SettingWindow.xaml was too long) Let's apply this task when working with valonia.

  • Change the Checkboxes to Toggle button in general / Hotkey / Proxy Tab

Before

image

After

image

Fix Plugins Designs

  • Fix Clickable Area
    image

  • Fix Hover Color

image

  • Adjust Some Colors

image

Fix Store with Darkmode
image
image

Why?

Test Case

  • Each Toggle Button must operate correctly.
  • The color shall be marked accurately when you mouse over the plugin item in plugin list
  • Even in dark mode, the color shall be displayed accurately.
  • There shall be no other effect on the virtual panel.

</Target>

<Target Name="RemoveDuplicateAnalyzers" BeforeTargets="CoreCompile">
<!-- Work around https://github.com/dotnet/wpf/issues/6792 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work around is no longer required?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. It should have been fixed in the latest version.

<StartupObject />
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two properties are not necessary now that the ci fix is merged in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i will remove them.

@taooceros taooceros enabled auto-merge November 13, 2022 16:56
@taooceros taooceros merged commit 83a14c1 into Flow-Launcher:dev Nov 13, 2022
@onesounds onesounds self-assigned this Nov 13, 2022
@onesounds onesounds added this to the 1.10.0 milestone Nov 13, 2022
@jjw24 jjw24 added enhancement New feature or request kind/ui related to UI, icons, themes, etc labels Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Refactor enhancement New feature or request kind/ui related to UI, icons, themes, etc

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants