Skip to content

Conversation

taooceros
Copy link
Member

@taooceros taooceros commented Nov 11, 2022

  • Recently CI fails because some weird issue that it detects the Flow.Launcher.Test.dll in path that contains an extra parent of Any CPU. This pr try to manually run the test to avoid that.

  • Also let the package run after test step is done

  • Added caching config to let the builds done faster

@jjw24
Copy link
Member

jjw24 commented Nov 12, 2022

Maybe we can get rid of that extra parent folder via the project file.

Can you link me to a failed ci?

@taooceros
Copy link
Member Author

taooceros commented Nov 12, 2022

Maybe we can get rid of that extra parent folder via the project file.

Can you link me to a failed ci?

#1528
you can also check the last few commits in #1524

I tried, and fails. Don't know what happens in the CI part

@jjw24
Copy link
Member

jjw24 commented Nov 12, 2022

Did Appveyor change something on their end or did we cause this bug?

@onesounds
Copy link
Contributor

@jjw24
Copy link
Member

jjw24 commented Nov 13, 2022

I have enabled caching for PR builds, which is what is ran per PR commit and by default is disabled:
https://www.appveyor.com/docs/build-cache/#saveupdate-cache-before-build-finishes

@jjw24 jjw24 changed the title Appveyor test executable unfound Appveyor test executable unfound fix and add caching Nov 13, 2022
@jjw24 jjw24 enabled auto-merge November 13, 2022 01:42
@jjw24 jjw24 added this to the 1.10.0 milestone Nov 13, 2022
@jjw24 jjw24 added bug Something isn't working enhancement New feature or request CI/CD labels Nov 13, 2022
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jjw24 jjw24 merged commit 3dd2b81 into dev Nov 13, 2022
@jjw24 jjw24 deleted the appveyor_ci_test branch November 13, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI/CD enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants