Skip to content

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Nov 12, 2022

what's the PR

  • Before : When you close the setting window in full screen state, it does not go into full screen state when you reopen it.
  • After : When you close the window in full screen state, it also opens to the full screen when you reopen it.

Test Cases

  • When you close and open the window, it should remain in the window state.
  • Window state should be maintained during program shutdown and rerun.
  • The window position should not change.

@onesounds onesounds self-assigned this Nov 12, 2022
@onesounds onesounds added the bug Something isn't working label Nov 12, 2022
@onesounds onesounds requested review from jjw24 and taooceros November 12, 2022 09:53
@jjw24 jjw24 enabled auto-merge November 12, 2022 10:07
@jjw24 jjw24 added this to the 1.10.0 milestone Nov 12, 2022
@jjw24
Copy link
Member

jjw24 commented Nov 12, 2022

Looks like CI failure as mentioned by tao in #1529

@jjw24 jjw24 removed this from the 1.10.0 milestone Nov 13, 2022
@jjw24 jjw24 changed the title Save Setting Window State (full / normal) [Dev] Save Setting Window State (full / normal) Nov 13, 2022
@jjw24 jjw24 merged commit ca47b4a into Flow-Launcher:dev Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants