Fix Change "Max Result Count" to be applied immediately #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onesounds
added
enhancement
taooceros
reviewed
Oct 20, 2021
| public double WindowLeft { get; set; } | ||
| public double WindowTop { get; set; } | ||
| public int MaxResultsToShow { get; set; } = 5; | ||
| public int MaxResultsToShow |
There was a problem hiding this comment.
Is fody not working well? It is not supposed that we need a onpropertychanged here
There was a problem hiding this comment.
Is fody not working well? It is not supposed that we need a onpropertychanged here
I'll search for "fody" and come back.
There was a problem hiding this comment.
I think I understand why fody not working here. Because the infrastructure repo don't include a reference for fody. Let's check whether we want to add fody to that project.
Fody is used to waive the need for writing propertychange in flow. https://github.com/Fody/PropertyChanged
|
#767 includes a change that should fix this. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #684.
Actually, it's not bug. There was no code to apply immediately when changing.