Add width in setting and fix max result displayed not reflected in real-time #767

onesounds · 2021-10-22T01:48:09Z

enhancements:

ignore width in theme
min 400, max 900. default 580, tick 10
Reflected in real time when the window is on.
also address the issue where max result displayed by the query window not reflected in real-time

outstanding issue

It's not reflected in the preview window. (I didn't make it. Do we need it?)
If you turn off shadow mode, there are some themes that are not reflected.
Some themes work even when shadows are off.
when I test it, even though the content is the same theme, (I copied metro server to light) something works and something not works.

close #766

- Add String "Window Width Size"

onesounds · 2021-10-22T07:56:50Z

Taoo modified it and now it works well functionally. When the slider is dragged, the query box is forcibly displayed so that changes can be viewed in real time. (It's more convenient for the user to check every time.) However, there is a problem when setting a specific point on the slider.

In this case, a kind of conflict occurs with the 'Hide when lost focus' setting. (OnDeactivated in mainwindow.xaml.cs) When using a slider, that option should not work, but no good way comes up with it. There are several attributes related to drag. https://newbedev.com/wpf-slider-with-an-event-that-triggers-after-a-user-drags

The simplest way is to make the slider only draggable.(in this case, the hidden focus setting is ignored, because user holding drag thumb.). I don't like it because it restricts general manipulation.

Clear query to prevent large area of window preventing user change width.

taooceros · 2021-10-22T18:42:12Z

I use a kind of dirty method to handle this. If it is considered too weird, I think don't showing the width is also reasonable.

taooceros · 2021-10-22T18:51:00Z

hmmmm I think there may exist some race tracing issue here..... Not sure how to solve that

taooceros · 2021-10-22T18:55:11Z

Hmmm the behavior is not good enough. Too much flickering appears. Maybe we show the width change in the preview panel?

This reverts commit 64a489b.

taooceros · 2021-10-22T20:26:30Z

Is it possible to add some space here

onesounds · 2021-10-23T03:14:29Z

Is it possible to add some space here

added height.

Hmmm the behavior is not good enough. Too much flickering appears. Maybe we show the width change in the preview panel?

yeah, I think it is more simple solution. I think this is enough.

…or binding issue)

taooceros · 2021-10-29T19:43:07Z

Flow.Launcher.Core/Resource/Theme.cs

-            }
-
+            var width = Settings.WindowSize;
+            windowStyle.Setters.Add(new Setter(Window.WidthProperty, width));


we don't need that right?

Have you remove all the width setting in the theme?

I didn't do it yet. Should I?

haven't this pr done that job? #755

I did so only for the elements inside the window. The themes currently pushed are fixed in window size.

ok nvm I remember the setter will be override by direct setting the width. Therefore, it shouldn't be a problem.

jjw24 · 2021-11-04T20:30:13Z

@onesounds @taooceros could we resolve the conflict in this one please

Flow.Launcher.Core/Resource/Theme.cs

jjw24

looks good. let's get the conflict resolved and merge in

taooceros · 2021-11-04T20:41:19Z

the conflict is a bit hard to resolve. I will do that tonght.

onesounds · 2021-11-05T01:15:24Z

the conflict is a bit hard to resolve. I will do that tonght.

It's easy for me to do because I did it when I made my version.
I don't know if it's okay to do it like this. anyway I merged with dev and pushed again.

taooceros · 2021-11-05T17:15:46Z

the conflict is a bit hard to resolve. I will do that tonght.

It's easy for me to do because I did it when I made my version. I don't know if it's okay to do it like this. anyway I merged with dev and pushed again.

I think you have done it right.
Let me take a check.

taooceros · 2021-11-05T17:25:37Z

I add auto reformat from plugin https://github.com/Xavalon/XamlStyler

onesounds and others added 10 commits October 20, 2021 23:58

add width slider

02036f1

Merge branch 'FixThemes' into SettingWidth

5938a9d

wip

616e98a

Adjust Width in Theme.cs

6af1262

- Remove Comment

5e0172c

- Add String "Window Width Size"

- Remove Comment

6b37ada

- Add String "Window Width Size"

adjust slider size

6aaca10

Add fody and use binding to change width

5be44b6

Display Querybox when Using Width slider.

674d615

Add "IsMoveToPointEnabled" property

08c643a

Use Hacky way to show up windows when width change.

64a489b

Clear query to prevent large area of window preventing user change width.

taooceros added 2 commits October 22, 2021 13:57

Revert "Use Hacky way to show up windows when width change."

a83f9df

This reverts commit 64a489b.

Bind width to preview

9d30960

Add Preview Height

22fb3f4

Use binding to control MinWidth and MaxWidth

fe90ebc

taooceros mentioned this pull request Oct 23, 2021

Fix Change "Max Result Count" to be applied immediately #766

Closed

- Move Seperator toggle style to mainwindow xaml (for preview separat…

bdcf419

…or binding issue)

taooceros assigned onesounds Oct 24, 2021

taooceros requested a review from jjw24 October 29, 2021 19:42

taooceros reviewed Oct 29, 2021

View reviewed changes

jjw24 reviewed Nov 4, 2021

View reviewed changes

Flow.Launcher.Core/Resource/Theme.cs Outdated Show resolved Hide resolved

remove obsolete comment

0a74766

jjw24 requested changes Nov 4, 2021

View reviewed changes

jjw24 added the bug Something isn't working label Nov 4, 2021

jjw24 added this to the 1.9.0 milestone Nov 4, 2021

onesounds added 2 commits November 5, 2021 10:12

merge dev for fix conflict

09992fa

Merge dev for fix conflict

6498c6b

Reformat xaml code

8ca8461

taooceros requested review from jjw24 and taooceros November 5, 2021 17:26

taooceros mentioned this pull request Nov 5, 2021

Default File manager #782

Merged

jjw24 changed the title ~~Width in setting~~ add Width in setting and fix max result displayed not reflected in real-time Nov 8, 2021

jjw24 changed the title ~~add Width in setting and fix max result displayed not reflected in real-time~~ Add width in setting and fix max result displayed not reflected in real-time Nov 8, 2021

jjw24 approved these changes Nov 8, 2021

View reviewed changes

jjw24 merged commit 8942e55 into Flow-Launcher:dev Nov 8, 2021

jjw24 mentioned this pull request Dec 5, 2021

Release 1.9.0 | Plugin 2.1.0 #697

Merged

Uh oh!

Add width in setting and fix max result displayed not reflected in real-time #767

Add width in setting and fix max result displayed not reflected in real-time #767

Uh oh!

Conversation

onesounds commented Oct 22, 2021 • edited by jjw24 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onesounds commented Oct 22, 2021

Uh oh!

taooceros commented Oct 22, 2021

Uh oh!

taooceros commented Oct 22, 2021

Uh oh!

taooceros commented Oct 22, 2021

Uh oh!

taooceros commented Oct 22, 2021

Uh oh!

onesounds commented Oct 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros Oct 29, 2021

Choose a reason for hiding this comment

Uh oh!

onesounds Oct 29, 2021

Choose a reason for hiding this comment

Uh oh!

taooceros Oct 29, 2021

Choose a reason for hiding this comment

Uh oh!

onesounds Oct 29, 2021

Choose a reason for hiding this comment

Uh oh!

taooceros Oct 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

onesounds Oct 30, 2021

Choose a reason for hiding this comment

Uh oh!

taooceros Oct 30, 2021

Choose a reason for hiding this comment

Uh oh!

jjw24 commented Nov 4, 2021

Uh oh!

Uh oh!

jjw24 left a comment

Choose a reason for hiding this comment

Uh oh!

taooceros commented Nov 4, 2021

Uh oh!

onesounds commented Nov 5, 2021

Uh oh!

taooceros commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros commented Nov 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

onesounds commented Oct 22, 2021 •

edited by jjw24

Loading

onesounds commented Oct 23, 2021 •

edited

Loading

taooceros Oct 30, 2021 •

edited

Loading

taooceros commented Nov 5, 2021 •

edited

Loading