Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jul 5, 2022

Description of proposed changes

Address #1989

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Jul 5, 2022
@seisman seisman added this to the 0.8.0 milestone Jul 5, 2022
@seisman seisman mentioned this pull request Jul 5, 2022
8 tasks
@seisman seisman changed the title Bump the minimum required GMT version to 6.4.0 Bump the GMT version in CI to 6.4.0 Jul 16, 2022
@seisman
Copy link
Member Author

seisman commented Jul 16, 2022

I've updated this PR based on the comment in #1991 (comment).

Now this PR only bumps the GMT version in CI to 6.4.0. The minimum required GMT version is still 6.3.0.

@seisman seisman requested a review from a team July 19, 2022 01:00
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Aug 2, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 4, 2022
@seisman seisman merged commit 25e9df4 into main Aug 4, 2022
@seisman seisman deleted the bump-gmt-6.4.0 branch August 4, 2022 02:21
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@weiji14 weiji14 mentioned this pull request Jan 7, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants