Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jan 7, 2024

Description of proposed changes

Address #2961.

Previous one at #1990

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@seisman seisman mentioned this pull request Jan 7, 2024
14 tasks
@seisman seisman added the maintenance Boring but important stuff for the core devs label Jan 7, 2024
@seisman seisman added this to the 0.11.0 milestone Jan 7, 2024
@seisman
Copy link
Member Author

seisman commented Jan 7, 2024

We have ~49 failures on Linux/macOS and ~55 failures on Windows. Not that bad. Will look at these failures in detail in later PRs.

@seisman seisman added the run/benchmark Trigger the benchmark workflow in PRs label Jan 7, 2024
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have ~49 failures on Linux/macOS and ~55 failures on Windows. Not that bad. Will look at these failures in detail in later PRs.

Thanks @seisman! I've listed those test failures in #2961 (comment). We can handle those in follow up PRs.

@weiji14 weiji14 changed the title Bump to GMT 6.5.0 Bump the GMT version in CI to 6.5.0 Jan 7, 2024
@weiji14 weiji14 merged commit 39827a9 into main Jan 7, 2024
@weiji14 weiji14 deleted the gmt/6.5.0 branch January 7, 2024 20:20
@seisman seisman removed the run/benchmark Trigger the benchmark workflow in PRs label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants