Use valid format for App Engine version string #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argument --version/-v: Bad value [doc-sample-appengine/hello-world/standard-standard]: May only contain lowercase letters, digits, and hyphens. Must begin and end with a letter or digit. Must not exceed 63 characters.
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Jun 15, 2018
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
=======================================
Coverage 48.52% 48.52%
=======================================
Files 1 1
Lines 68 68
=======================================
Hits 33 33
Misses 35 35Continue to review full report at Codecov.
|
Shabirmean
pushed a commit
that referenced
this pull request
Feb 16, 2023
Shabirmean
pushed a commit
that referenced
this pull request
Feb 16, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.1](https://www.github.com/googleapis/nodejs-dlp/compare/v3.2.0...v3.2.1) (2021-11-03) ### Bug Fixes * **deps:** update dependency mime to v3 ([#663](https://www.github.com/googleapis/nodejs-dlp/issues/663)) ([5d33ead](https://www.github.com/googleapis/nodejs-dlp/commit/5d33ead5c207511a2ef3d268dd804eabc20408d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argument --version/-v: Bad value
[doc-sample-appengine/hello-world/standard-standard]: May only contain
lowercase letters, digits, and hyphens. Must begin and end with a
letter or digit. Must not exceed 63 characters.
I'll delete
APPENGINE_ENVIRONMENTfrom the list of allowed environment variables in the matching job configs.