Skip to content

Use valid format for App Engine version string #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Use valid format for App Engine version string #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .kokoro/appengine/test-deployment/hello-world-flex.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@
env_vars: {
key: "PROJECT"
value: "appengine/hello-world/flexible"
}

# flexible or standard
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "flexible"
}
6 changes: 0 additions & 6 deletions .kokoro/appengine/test-deployment/hello-world-standard.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@
env_vars: {
key: "PROJECT"
value: "appengine/hello-world/standard"
}

# flexible or standard
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "standard"
}
6 changes: 0 additions & 6 deletions .kokoro/appengine/test-deployment/metadata-flex.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@
env_vars: {
key: "PROJECT"
value: "appengine/metadata/flexible"
}

# flexible or standard
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "flexible"
}
6 changes: 0 additions & 6 deletions .kokoro/appengine/test-deployment/metadata-standard.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@
env_vars: {
key: "PROJECT"
value: "appengine/metadata/standard"
}

# flexible or standard
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "standard"
}
6 changes: 0 additions & 6 deletions .kokoro/appengine/test-deployment/storage-flex.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@
env_vars: {
key: "PROJECT"
value: "appengine/storage/flexible"
}

# flexible or standard
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "flexible"
}
6 changes: 0 additions & 6 deletions .kokoro/appengine/test-deployment/storage-standard.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@
env_vars: {
key: "PROJECT"
value: "appengine/storage/standard"
}

# flexible or standard
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "standard"
}
2 changes: 1 addition & 1 deletion .kokoro/build-with-appengine.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ gcloud auth activate-service-account --key-file "$GOOGLE_APPLICATION_CREDENTIALS
gcloud config set project $GCLOUD_PROJECT

export NODE_ENV=development
export GAE_VERSION=doc-sample-${PROJECT}-${APPENGINE_ENVIRONMENT}
export GAE_VERSION=doc-sample-$(echo $PROJECT | sed 's_/_-_g')

# Register post-test cleanup
function cleanup {
Expand Down