Skip to content

Fix libraries in linux module wheels #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix libraries in linux module wheels #265

wants to merge 2 commits into from

Conversation

SimonRit
Copy link

@SimonRit SimonRit commented Feb 14, 2024 •
edited
Loading

The goal is to fix #263. The second commit inform auditwheel on where are the wheels libraries. However, it does not seem to work so far, see the wheels produced by https://github.com/RTKConsortium/ITKCudaCommon/actions/runs/7901454685 which contain renamed versions of libcuda.so and libcudart.so, e.g.:

srit@srit-Precision-5480:~/tmp$ unzip LinuxWheel310-cuda116.zip 
Archive:  LinuxWheel310-cuda116.zip
  inflating: itk_cudacommon_cuda116-1.0.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl  
  inflating: itk_cudacommon_cuda116-1.0.1-cp310-cp310-manylinux_2_28_x86_64.whl  
srit@srit-Precision-5480:~/tmp$ unzip ../itk_cudacommon_cuda116-1.0.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl  
Archive:  ../itk_cudacommon_cuda116-1.0.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
   creating: itk/
   creating: itk_cudacommon_cuda116-1.0.1.dist-info/
   creating: itk_cudacommon_cuda116.libs/
   creating: itk/Configuration/
  inflating: itk/CudaCommonPython.py  
  inflating: itk/_CudaCommonPython.so  
  inflating: itk/itkCudaDataManagerPython.py  
  inflating: itk/itkCudaImageDataManagerPython.py  
  inflating: itk/itkCudaImagePython.py  
  inflating: itk/itkImageSourceCudaCommonPython.py  
  inflating: itk/itkImageToImageFilterCudaCommonPython.py  
  inflating: itk/Configuration/CudaCommonConfig.py  
  inflating: itk/Configuration/CudaCommon_snake_case.py  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/LICENSE  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/METADATA  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/WHEEL  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/top_level.txt  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/RECORD  
  inflating: itk_cudacommon_cuda116.libs/libcudart-45da57e3.so.11.6.55  
  inflating: itk_cudacommon_cuda116.libs/libtbb-b694c9f9.so.12.9  
  inflating: itk_cudacommon_cuda116.libs/libcuda-b083b9ef.so.1

I'll keep trying but maybe the whitelist strategy in auditwheel does not work anymore? Or I missed something? cc @LucasGandel

Simon Rit added 2 commits February 13, 2024 22:23
BUG: Fix management of policies with newer auditwheel
32bafc5 
cf8c3f3 introduced an option to exclude
libraries from the wheel using auditwheel lib_whitelist policy. This
patch adapts ITKPythonPackage code to the new management of policies by
auditwheel since pypa/auditwheel@4886850
BUG: add mounted library paths to docker LD_LIBRARY_PATH
b48bfbf
@SimonRit SimonRit changed the title Fix libraries in module linux wheels Fix libraries in linux module wheels Feb 14, 2024
@dzenanz dzenanz requested a review from thewtex February 14, 2024 15:37
@SimonRit
Copy link
Author

Actually audithweel has now an exclude mechanism which should remove the need for the monkey patch, see
pypa/auditwheel@0a2fdd1.
Being tested...

@SimonRit SimonRit mentioned this pull request Feb 14, 2024
Merged
@SimonRit
Copy link
Author

Superseded by #266

@SimonRit SimonRit closed this Feb 14, 2024
@SimonRit SimonRit deleted the WheelPolicies branch February 16, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex Awaiting requested review from thewtex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auditwheel policy adjustments not applied in latest auditwheel
1 participant
@SimonRit