Exclude libraries from auditwheel

[SimonRit]

This PR

• greatly simplifies the handling of the --exclude_libs option thanks to a new --exclude option of auditwheel. This has been tested and seems to work, see CudaCommon CI packaging and the result (compared to Fix libraries in linux module wheels #265):

- srit@srit-Precision-5480:~/tmp$ unzip LinuxWheel310-cuda116.zip 
Archive:  ../LinuxWheel310-cuda116.zip
  inflating: itk_cudacommon_cuda116-1.0.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl  
  inflating: itk_cudacommon_cuda116-1.0.1-cp310-cp310-manylinux_2_28_x86_64.whl  
srit@srit-Precision-5480:~/tmp$ unzip itk_cudacommon_cuda116-1.0.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
Archive:  itk_cudacommon_cuda116-1.0.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
   creating: itk/
   creating: itk_cudacommon_cuda116-1.0.1.dist-info/
   creating: itk_cudacommon_cuda116.libs/
   creating: itk/Configuration/
  inflating: itk/CudaCommonPython.py  
  inflating: itk/_CudaCommonPython.so  
  inflating: itk/itkCudaDataManagerPython.py  
  inflating: itk/itkCudaImageDataManagerPython.py  
  inflating: itk/itkCudaImagePython.py  
  inflating: itk/itkImageSourceCudaCommonPython.py  
  inflating: itk/itkImageToImageFilterCudaCommonPython.py  
  inflating: itk/Configuration/CudaCommonConfig.py  
  inflating: itk/Configuration/CudaCommon_snake_case.py  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/LICENSE  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/METADATA  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/WHEEL  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/top_level.txt  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/RECORD  
  inflating: itk_cudacommon_cuda116.libs/libtbb-b694c9f9.so.12.9  

• includes in the docker LD_LIBRARY_PATH the library paths to forward it to auditwheel.

[SimonRit]

cc @LucasGandel

[dzenanz]

This looks like a great fix.

[thewtex]

@SimonRit thanks!

LGTM

@LucasGandel please take a look

[LucasGandel]

The change to use the new --exclude option looks good, thanks a lot!
I can't tell for the LD_LIBRARY_PATH change though.

[SimonRit]

I can't tell for the LD_LIBRARY_PATH change though.

I made it because auditwheel could not find the shared libraries otherwise. Maybe it was working before thanks to the whitelist? I honestly don't know why...

[dzenanz]

How does this change in light of this PR being merged? I tried using it here, without much luck.

[SimonRit]

without much luck.

The error message in the failing build seems unrelated
Could NOT find SWIG (missing: SWIG_DIR)
I'm not sure what's the problem here...

[dzenanz]

Maybe it is related to 96e3477?

[SimonRit]

Maybe it is related to 96e3477?

Possibly but I could not figure out why the CudaCommon CI had a different cmake command line, with the new options of this commit and not the former one as yours.