Skip to content

Fix trigger of fetcher tests #12619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Fix trigger of fetcher tests #12619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/tests-fetchers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ on:
paths:
- 'src/main/java/org/jabref/logic/importer/fetcher/**'
- 'src/test/java/org/jabref/logic/importer/fetcher/**'
- 'src/main/java/org/jabref/logic/importer/fileformat/PdfMergeMetadataImporter.java'
Copy link
Member

@InAnYan InAnYan Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking: what about adding whole importer/**? Importers != fetchers?

Copy link
Member Author

@koppor koppor Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • importers work on the local file system
  • fetchers work on remoate
  • PdfMergeMetaDataImporter is a "hybrid", because it works on the file system, but also uses external sourfces

Aim of having less triggers: Not hitting any rate limit.

Copy link
Member Author

@koppor koppor Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where to note that down? package-info.java in package org.jabref.logic.importer.fetcher?

- 'src/test/java/org/jabref/logic/importer/fileformat/PdfMergeMetadataImporterTest.java'
- 'src/main/java/org/jabref/logic/crawler/**'
- 'src/test/java/org/jabref/logic/crawler/**'
- '.github/workflows/tests-fetchers.yml'
Expand All @@ -15,6 +17,10 @@ on:
paths:
- 'src/main/java/org/jabref/logic/importer/fetcher/**'
- 'src/test/java/org/jabref/logic/importer/fetcher/**'
- 'src/main/java/org/jabref/logic/importer/fileformat/PdfMergeMetadataImporter.java'
- 'src/test/java/org/jabref/logic/importer/fileformat/PdfMergeMetadataImporterTest.java'
- 'src/main/java/org/jabref/logic/crawler/**'
- 'src/test/java/org/jabref/logic/crawler/**'
- '.github/workflows/tests-fetchers.yml'
- 'build.gradle'
schedule:
Expand Down