Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Mar 4, 2025

Follow-up to #8258 -> org.jabref.logic.importer.fileformat.pdf.PdfMergeMetadataImporterTest is marked as fetcher test. Thus, fetcher tests should run if a change in this file occurs.

Whole thing triggered by #12088 rendering a test not working, but did not show up, because no fetcher tests ran.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

paths:
- 'src/main/java/org/jabref/logic/importer/fetcher/**'
- 'src/test/java/org/jabref/logic/importer/fetcher/**'
- 'src/main/java/org/jabref/logic/importer/fileformat/PdfMergeMetadataImporter.java'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking: what about adding whole importer/**? Importers != fetchers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • importers work on the local file system
  • fetchers work on remoate
  • PdfMergeMetaDataImporter is a "hybrid", because it works on the file system, but also uses external sourfces

Aim of having less triggers: Not hitting any rate limit.

Copy link
Member Author

@koppor koppor Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where to note that down? package-info.java in package org.jabref.logic.importer.fetcher?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor mentioned this pull request Mar 4, 2025
4 tasks
@koppor koppor enabled auto-merge March 4, 2025 13:17
@koppor koppor added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit 25a739c Mar 4, 2025
1 check passed
@koppor koppor deleted the fix-trigger branch March 4, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants